Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some fields to the report #100

Merged
merged 9 commits into from
Jan 20, 2021
Merged

Add some fields to the report #100

merged 9 commits into from
Jan 20, 2021

Conversation

jasalisbury
Copy link

@jasalisbury jasalisbury commented Dec 23, 2020

Description of change

Added some fields to the report:

  • Activity summary: participants, reasons and target populations
  • Goals & Objectives: context

Keeping as draft until these fields can be saved to the database. Wanted to get this up before the break so I have an easier time picking up where I left off.

How to test

These fields do not currently save to the database.

  1. Pull down
  2. Fill out the report. Note participants, reasons and target population options are the "finalized" options

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

 * Activity summary: participants, reasons and target populations
 * Goals & Objectives: context
@jasalisbury jasalisbury marked this pull request as draft January 4, 2021 22:25
Conflicts:
	frontend/src/pages/ActivityReport/Pages/activitySummary.js
	frontend/src/pages/ActivityReport/Pages/goalsObjectives.js
	frontend/src/pages/ActivityReport/index.js
@jasalisbury jasalisbury requested review from dcmcand and removed request for SarahJaine January 20, 2021 16:10
@jasalisbury jasalisbury marked this pull request as ready for review January 20, 2021 16:10
@kryswisnaskas
Copy link
Collaborator

Looks good! Works as advertised. 👍

Copy link

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Nice job.

@jasalisbury jasalisbury merged commit 1c9ee97 into main Jan 20, 2021
@jasalisbury jasalisbury deleted the js-add-report-fields branch January 20, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants