[FLINK-37103] The parameters passed when calling method FactoryUtil.createDynamicTableSource are inconsistent

[zhuanshenbsj1]

What is the purpose of the change

It seems that this pr #25559 lacks the change here.

Brief change log

(for example:)

• The TaskInfo is stored in the blob store on job creation time as a persistent artifact
• Deployments RPC transmits only the blob storage reference
• TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (100MB)
• Extended integration test for recovery after master (JobManager) failure
• Added test that validates that TaskInfo is transferred only once across recoveries
• Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

CI report:

• dfab072 Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[zhuanshenbsj1]

@luoyuxia @wuchong cc~

[wuchong]

cc @fsk119 this PR fixes failures in hive connector module.

[davidradl]

We have externalized the Hive connector https://github.com/apache/flink-connector-hive. We have not yet released it; but there is work underway to release a 1.20 Hive connector apache/flink-connector-hive#20. I suggest closing out this PR and looking in the flink hive connector repo and raising the PR there if appropriate. fyi @snuyanzin

[fsk119]

According to the discussion[1], we should not open new PR about hive in flink repo. Could you open a new PR for the flink-hive repo?

[1] https://issues.apache.org/jira/browse/FLINK-37097

[zhuanshenbsj1]

We have externalized the Hive connector https://github.com/apache/flink-connector-hive. We have not yet released it; but there is work underway to release a 1.20 Hive connector apache/flink-connector-hive#20. I suggest closing out this PR and looking in the flink hive connector repo and raising the PR there if appropriate. fyi @snuyanzin

OK, I will migrate the PR to the new repository

[zhuanshenbsj1]

According to the discussion[1], we should not open new PR about hive in flink repo. Could you open a new PR for the flink-hive repo?

[1] https://issues.apache.org/jira/browse/FLINK-37097

Roger that.

[davidradl]

Reviewed by Chi on 16/01/2025 Go back to the submitter with review comments.