Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: added Docker image for visualization plugins #5460

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 20, 2024

Description

This PR adds support for building a visualization-only Docker image.

Related links

#5076

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@esteve esteve self-assigned this Nov 20, 2024
@esteve esteve force-pushed the docker-image-visualization branch from c755782 to 6f32bde Compare December 16, 2024 14:54
Copy link

github-actions bot commented Dec 16, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve force-pushed the docker-image-visualization branch 2 times, most recently from 091ac8a to db92218 Compare January 13, 2025 10:10
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the docker-image-visualization branch from 6d9bef4 to 31a6c99 Compare January 14, 2025 14:17
@esteve esteve marked this pull request as ready for review January 14, 2025 14:19
@esteve esteve requested review from xmfcx and mitsudome-r January 14, 2025 14:20
@esteve
Copy link
Contributor Author

esteve commented Jan 14, 2025

@mitsudome-r @oguzkaganozt @youtalk @xmfcx in addition to adding support for building a visualization-only Docker image, I've added a --target option to build.sh so that we can build any image that's been declared as a target.

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following line to https://github.com/autowarefoundation/autoware/pull/5460/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddcR370.

COPY --from=universe-visualization-devel /opt/autoware /opt/autoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
Copy link
Contributor Author

esteve commented Jan 15, 2025

@youtalk done in 8e53d68

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit b2c7255 into autowarefoundation:main Jan 15, 2025
18 checks passed
@esteve esteve deleted the docker-image-visualization branch January 15, 2025 13:08
@esteve
Copy link
Contributor Author

esteve commented Jan 15, 2025

@youtalk thanks for the review 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants