-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(.github): update github-release
workflow
#5652
Open
youtalk
wants to merge
7
commits into
autowarefoundation:main
Choose a base branch
from
youtalk:chore/update-github-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(.github): update github-release
workflow
#5652
youtalk
wants to merge
7
commits into
autowarefoundation:main
from
youtalk:chore/update-github-release
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
youtalk
changed the title
chore(.github): update
docs(.github): fix Jan 14, 2025
github-release
actiongithub-release
action
youtalk
changed the title
docs(.github): fix
docs(.github): fix Jan 14, 2025
github-release
actiongithub-release
workflow
youtalk
changed the title
docs(.github): fix
fix(.github): update Jan 14, 2025
github-release
workflowgithub-release
workflow
youtalk
added
type:github-actions
Github actions related. (auto-assigned)
tag:run-health-check
Run health-check
labels
Jan 14, 2025
I think these are may cause some mild problems in the future:
What do you think ? @youtalk |
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@oguzkaganozt I've applied your suggestion. Please review again. The test was also passed. https://github.com/youtalk/autoware/actions/runs/12821081649/job/35751719529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
github-release
workflow so that the GitHub release page is correctly generated when a version tag is pushed.How was this PR tested?
The result of executing a
workflow_dispatch
trigger withtag-name
set to0.40.0
in my forked repository:https://github.com/youtalk/autoware/releases/tag/untagged-abca71c3a111e29fae42
Notes for reviewers
None.
Effects on system behavior
None.