fix(data-table): input name is stable while id is unique (#2088)

carbon-design-system · Jan 20, 2025 · 9d66653 · 9d66653
1 parent 153a28e
commit 9d66653
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/DataTable/DataTable.svelte b/src/DataTable/DataTable.svelte
@@ -381,6 +381,8 @@
             <InlineCheckbox
               bind:ref={refSelectAll}
               aria-label="Select all rows"
+              name="{id}-select-all"
+              value="all"
               checked={selectAll}
               {indeterminate}
               on:change={(e) => {
@@ -512,9 +514,12 @@
               class:bx--table-column-radio={radio}
             >
               {#if !nonSelectableRowIds.includes(row.id)}
+                {@const inputId = `${id}-${row.id}`}
+                {@const inputName = `${id}-name`}
                 {#if radio}
                   <RadioButton
-                    name="{id}-{row.id}"
+                    id={inputId}
+                    name={inputName}
                     checked={selectedRowIds.includes(row.id)}
                     on:change={() => {
                       selectedRowIds = [row.id];
@@ -523,7 +528,8 @@
                   />
                 {:else}
                   <InlineCheckbox
-                    name="{id}-{row.id}"
+                    id={inputId}
+                    name={inputName}
                     checked={selectedRowIds.includes(row.id)}
                     on:change={() => {
                       if (selectedRowIds.includes(row.id)) {

diff --git a/tests/DataTable/DuplicateDataTables.test.svelte b/tests/DataTable/DuplicateDataTables.test.svelte
@@ -14,3 +14,6 @@
 
 <DataTable radio {headers} {rows} />
 <DataTable radio {headers} {rows} />
+
+<DataTable batchSelection selectable {headers} {rows} />
+<DataTable batchSelection selectable {headers} {rows} />