Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional project_id field to UpdateFileRequest #540

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

kang2453
Copy link
Contributor

@kang2453 kang2453 commented Jan 7, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

feat: add optional project_id field to UpdateFileRequest

Known issue

@kang2453 kang2453 added the enhancement New feature or request label Jan 7, 2025
@kang2453 kang2453 self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

⚠️ @kang2453 the signed-off-by was not found in the following 1 commits:

  • 2ae7ad4: Merge branch 'cloudforet-io:master' into master

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@kang2453 kang2453 merged commit 2cc031d into cloudforet-io:master Jan 7, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fail/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant