Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dotnet test help option #41142
Implement dotnet test help option #41142
Changes from 31 commits
8f7b82c
19393e0
8d61d89
20f5b1a
9f6f951
1c93e3b
1b8db4b
1c38cc1
7c04a05
b5e8c18
23bb5ac
f6b3cd6
b1a64fd
698c7e8
ab171f5
7c14c93
6fdd73d
b7070a0
f4cb57e
2cf9cb2
46f7200
ca41b0d
097d9ba
4801c6e
dfc7cb7
89b8f76
81a3e90
15c652e
4af142c
1f69b2d
5e4347a
ff1880c
6c55c56
208ae67
da9ffba
87074d7
2aa8506
fae7748
9138671
a8fba78
cdc6d94
46cb20d
3d37391
88e5dc9
d0b41f0
e96af9c
9f7d0ab
b1d85db
de47bb4
2c2501e
e4271e9
07d37fd
d9c9839
5484b06
79ed573
98be087
9f2acd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you won't have to disable the warnings if you reverse the order of these interfaces, i.e.,
IClient :
#if NETCOREAPP
IAsyncDisposable,
#endif
IDisposable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariam-abdulla pls give it a try looks a good idea! thanks