Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump engines requirement to Node 22 #1167

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

erikian
Copy link
Member

@erikian erikian commented Jan 16, 2025

BREAKING CHANGE: bumps required Node.js version to >=22.0.0

I also took the opportunity to update farmhash to 3.3.1 in one of the test fixtures so we can run a couple of test cases we were skipping on arm64 macOS. I tried switching to 4.0.1 but it would require some deeper changes in the tests, so I figured it would be a good idea to address that in a follow-up PR as 3.3.1 is enough to get those tests running for the Node upgrade.

@electron electron deleted a comment from notion-workspace bot Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant