Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recent PRs to PR Lookup #69

Merged
merged 2 commits into from
Dec 19, 2024
Merged

feat: add recent PRs to PR Lookup #69

merged 2 commits into from
Dec 19, 2024

Conversation

codebytere
Copy link
Member

Improve UI of PR Lookup by adding recent PRs in the style of ChromiumDash. Also improve some of the styling.

Screenshot 2024-12-10 at 3 47 25 PM

@codebytere codebytere requested review from a team as code owners December 10, 2024 15:49
@codebytere codebytere force-pushed the recent-prs branch 3 times, most recently from 74e6898 to fef1f5d Compare December 10, 2024 15:52
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you think it would be reasonable to tweak it so that clicking on a row takes you to the PR lookup for that PR? UX wise it's a bit unintuitive that I can't click the PR and have to manually type the number in to look it up. Maybe we could keep the link to the GitHub PR but put it as a GitHub logo icon next to the PR number and have that be the link?

src/data.js Show resolved Hide resolved
src/data.js Outdated Show resolved Hide resolved
@codebytere codebytere merged commit ad0474d into main Dec 19, 2024
2 checks passed
@codebytere codebytere deleted the recent-prs branch December 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants