Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajv data filtering #12

Merged
merged 14 commits into from
May 14, 2018
Merged

Ajv data filtering #12

merged 14 commits into from
May 14, 2018

Conversation

danalexilewis
Copy link
Member

@danalexilewis danalexilewis commented May 12, 2018

Key additions are:

  • Using ajv to both validate and filter the data being processed. This guarantees that we wont be leaking private data by accident and consistent data shape for the front end.

  • using js-md5 to create a hash of a persons public email to create the users gravatar url.

closes #4 #3

@danalexilewis danalexilewis requested a review from dazyang May 12, 2018 11:01
@danalexilewis
Copy link
Member Author

@dazyang I have moved the gravatar computation here so we can show the picture of a person even if they dont want to show their email.

I have also reduced the data shape of general people as per the people.json. I am going to write a similar one for the ambassadors and submit it in another pull request. in the meantime have a review of this.

Note: I have not yet updated the api - as when I do it is going to break the front end as all the keys have been camelCased.

@dazyang dazyang merged commit 1694081 into master May 14, 2018
@danalexilewis danalexilewis deleted the ajv-data-filtering branch May 22, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide unneeded Airtable fields
2 participants