Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2025-01-16] Bump dependency updates identified by dependabot #19209

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

Reference:
- etcd-io#19186

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Reference:
- etcd-io#19185

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Reference:
- etcd-io#19184

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
…google.golang.org/genproto/googleapis/api from v0.0.0-20241219192143-6b3ec007d9bb to v0.0.0-20250102185135-69823020774d, and google.golang.org/genproto/googleapis/rpc from v0.0.0-20241219192143-6b3ec007d9bb to v0.0.0-20250102185135-69823020774d

Reference:
- etcd-io#19182

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (ab819b5) to head (b338550).
Report is 10 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19209   +/-   ##
=======================================
  Coverage   68.84%   68.84%           
=======================================
  Files         420      420           
  Lines       35635    35635           
=======================================
  Hits        24533    24533           
- Misses       9686     9692    +6     
+ Partials     1416     1410    -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab819b5...b338550. Read the comment docs.

@henrybear327
Copy link
Contributor Author

/retest

2 similar comments
@henrybear327
Copy link
Contributor Author

/retest

@henrybear327
Copy link
Contributor Author

/retest

@ivanvc
Copy link
Member

ivanvc commented Jan 17, 2025

@henrybear327, I think there's a genuine issue with the robustness tests (it happened here, too: #19105 (comment))

@henrybear327
Copy link
Contributor Author

@henrybear327, I think there's a genuine issue with the robustness tests (it happened here, too: #19105 (comment))

Will dig into the logs and see if there is anything of interest going on. Last week it was fine though.

@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

@henrybear327, I think there's a genuine issue with the robustness tests (it happened here, too: #19105 (comment))

Some test were timedout , it looks like the test environment issue. I noticed that the test infra isn't stable recently. Did you notice any known issue of the test infra recently? @ivanvc

Some test were failed, but I did not see any obvious error or failure in the test. It's weird, we may need to enhance the robustness test itself. For example, in here, there are 11 rounds of test for some test case, the first round always failed, but I do not see any error or failure in the first round. cc @serathius

@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

/retest

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivanvc @jmhbnz PTAL, thx

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Henry.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b4e9d81 into etcd-io:main Jan 17, 2025
40 checks passed
@henrybear327 henrybear327 self-assigned this Jan 19, 2025
@henrybear327 henrybear327 deleted the dependencies/25_01_16 branch January 19, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants