Skip to content

Commit

Permalink
Fix tests & linter errors
Browse files Browse the repository at this point in the history
  • Loading branch information
mszeszko-meta committed Jan 17, 2025
1 parent b921942 commit 3e8684b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion utilities/backup/backup_engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3054,7 +3054,6 @@ void BackupEngineImpl::InferDBFilesToRetainInRestore(
continue;
}

auto backup_checksum_hex = it->second;
if (it->second != result.checksum_hex) {
Log(options_.info_log,
"Checksum mismatch between backup file and existing file '%s'.",
Expand Down
8 changes: 1 addition & 7 deletions utilities/backup/backup_engine_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1151,12 +1151,6 @@ TEST_F(BackupEngineTest, IncrementalRestore) {
}
}

// Files filled with data have lower #s.
// It's handy to know which files are non-empty and
// therefore easier to corrupt for the sake of testing.
std::sort(all_sst_files.begin(), all_sst_files.end());
std::sort(all_blob_files.begin(), all_blob_files.end());

std::string one_sst_file = all_sst_files[0];

// 2. Verify expected behavior with exclude files feature.
Expand Down Expand Up @@ -1265,7 +1259,7 @@ TEST_F(BackupEngineTest, IncrementalRestore) {
// (by overriding bytes beyond the footer) to corrupt a file in a more
// harmful way...
std::string sst_file_to_be_corrupted = all_sst_files[0];
ASSERT_OK(db_file_manager_->CorruptFileMiddle(sst_file_to_be_corrupted));
ASSERT_OK(db_file_manager_->CorruptFileStart(sst_file_to_be_corrupted));

OpenBackupEngine();

Expand Down

0 comments on commit 3e8684b

Please sign in to comment.