Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Pathway Allocators (v5) #15

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 18, 2024

  • feat: update LDN clients
  • feat: add support for Pathway Allocators (v5)

Also add https://github.com/fidlabs/Open-Data-Pathway as the first known allocator that requires stored data to be publicly retrievable.

Links:

bajtos added 2 commits June 18, 2024 15:39
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Also add https://github.com/fidlabs/Open-Data-Pathway as the first
known allocator that requires stored data to be publicly retrievable.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber June 18, 2024 15:35
@bajtos
Copy link
Member Author

bajtos commented Jun 18, 2024

The second commit added the following three new clients that would not be picked up before my changes:

  • f02011705
  • f03123037
  • f03139621

See d59ff9e#diff-f473a777bc0662fb256384ee2c76d96e36706572292e63ccfe834ab5ee7b324f

@bajtos
Copy link
Member Author

bajtos commented Jun 18, 2024

Hmm, my intention was to push the first commit directly to the main branch and then keep only the second commit in this pull request. 🙈

@juliangruber
Copy link
Member

Hmm, my intention was to push the first commit directly to the main branch and then keep only the second commit in this pull request. 🙈

if you push the first commit to main then this PR will only contain the 2nd :) should be straight forward with git cherry-pick

Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all lgtm 👏

@bajtos
Copy link
Member Author

bajtos commented Jun 20, 2024

Hmm, my intention was to push the first commit directly to the main branch and then keep only the second commit in this pull request. 🙈

if you push the first commit to main then this PR will only contain the 2nd :) should be straight forward with git cherry-pick

Yes, that's what I though, but it didn't work out.

Screenshot 2024-06-20 at 08 51 27 Screenshot 2024-06-20 at 08 51 31

@bajtos bajtos merged commit 0833788 into main Jun 20, 2024
@bajtos bajtos deleted the track-pathway-allocators branch June 20, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants