Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip about non-parallel builds to README #477

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add tip about non-parallel builds to README #477

merged 1 commit into from
Jan 3, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jan 2, 2024

Summary

This has come up multiple times now, so it's better to document it. #474 (comment), #401 (comment)

The [!TIP] syntax is from https://github.com/orgs/community/discussions/16925.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from ahcorde as a code owner January 2, 2024 22:53
@ahcorde ahcorde merged commit 490f4d5 into ros2 Jan 3, 2024
8 checks passed
@ahcorde ahcorde deleted the azeey-patch-1 branch January 3, 2024 10:00
@ahcorde
Copy link
Collaborator

ahcorde commented Jan 3, 2024

https://github.com/Mergifyio backport humble iron

ahcorde pushed a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde pushed a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde added a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde added a commit that referenced this pull request Jan 3, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
caguero pushed a commit that referenced this pull request Mar 29, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants