Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Remove some Objective-C specific query code #18514

Merged
merged 1 commit into from
Jan 17, 2025
Merged

C++: Remove some Objective-C specific query code #18514

merged 1 commit into from
Jan 17, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jan 16, 2025

We have not supported Objective-C for a long time.

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema
C++: Remove some Objective-C specific query code
aec151d 
We have not supported Objective-C for a long time.
@github-actions github-actions bot added the C++ label Jan 16, 2025
@jketema jketema added the no-change-note-required This PR does not need a change note label Jan 16, 2025
@jketema jketema marked this pull request as ready for review January 16, 2025 14:35
@Copilot Copilot bot review requested due to automatic review settings January 16, 2025 14:35
@jketema jketema requested a review from a team as a code owner January 16, 2025 14:35
Copilot
Copilot AI reviewed Jan 16, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
geoffw0
geoffw0 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jketema jketema merged commit 65a11e4 into github:main Jan 17, 2025
15 checks passed
@jketema jketema deleted the objc branch January 17, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @geoffw0