-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement duration rounding #301
base: main
Are you sure you want to change the base?
Conversation
936397b
to
f936f7a
Compare
I have moved the implementation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking good 👍. There are some failing tests which need to be addressed please, but overall I like the shape of this.
This is expected and I have mentioned in my new pull request description: "As this is an isolated pull request, tests will appear to fail until changes from the other pull requests of the set are integrated." Particularly, the tests are based on the usage of the new implementations of |
That's fine, more meant as a note for colleagues. I'd like us to merge in an order which maintains the health of the main branch, if we can (despite the current failing test in main).
Which other PRs do you anticipate will reduce the test failures on this one? |
(This is part of a set of multiple pull requests looking to overhaul the calculation functions.)
This pull request reimplements the
roundToSingleUnit
function with more robust logic. The original date is now computed through theapplyDuration
function (a new implementation is in #298).As this is an isolated pull request, tests will appear to fail until changes from the other pull requests of the set are integrated.