-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion of rename organization api #33303
base: main
Are you sure you want to change the base?
Conversation
b14c5e7
to
ff24828
Compare
Signed-off-by: Bruno Sofiato <bruno.sofiato@gmail.com>
ctx.ServerError("RenameOrg", err) | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can reference the implementation here: gitea/routers/api/v1/admin/user.go Lines 475 to 502 in 7582eb0
|
It's better to have a test. |
This adds an endpoint (
/orgs/{org}/rename
) to rename organizations.I've modeled the endpoint using the rename user endpoint --
/admin/users/{username}/rename
-- as base.It is the 1st time I wrote a new API endpoint (I've tried to follow the rename users endpoint code while writing it). So feel free to ping me if there is something wrong or missing.
Resolves #32995