Add missed auto merge feed message on dashboard #33309
Open
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
pull-request-size
bot
added
size/S
silverwind
approved these changes
Jan 17, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jan 17, 2025
templates/user/dashboard/feeds.tmpl
Outdated
| {{else if .GetOpType.InActions "auto_merge_pull_request"}} | ||
| {{$index := index .GetIssueInfos 0}} | ||
| {{$title := index .GetIssueInfos 1}} | ||
| {{ctx.Locale.Tr "action.auto_merge_pull_request" (printf "%s/pulls/%s" (.GetRepoLink ctx) $index) $index (.ShortRepoPath ctx) $title}} |
There was a problem hiding this comment.
Just copied and pasted the code without checking it?
auto_merge_pull_request = `automatically merged pull request <a href="%[1]s">%[3]s#%[2]s</a>`
But you put 4 arguments here?
(printf "%s/pulls/%s" (.GetRepoLink ctx) $index)$index(.ShortRepoPath ctx)$title
There was a problem hiding this comment.
799ac4f The last argument $title should be removed.
There was a problem hiding this comment.
I do not see how really you fixed the copy-paste code.
If $title should be removed, why there is still {{$title := index .GetIssueInfos 1}} in the new commit?
GiteaBot
added
lgtm/need 2
lafriks
approved these changes
Jan 19, 2025
GiteaBot
added
lgtm/need 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.