feat: Add manage_ghes endpoints introduced in 3.15 #3433

s4mur4i · 2025-01-15T18:02:32Z

codecov · 2025-01-15T19:19:28Z

Codecov Report

Attention: Patch coverage is 94.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.29%. Comparing base (2b8c7fa) to head (c4121e9).
Report is 223 commits behind head on master.

Files with missing lines	Patch %	Lines
github/enterprise_manage_ghes.go	88.88%	4 Missing and 2 partials ⚠️
github/enterprise_manage_ghes_config.go	95.16%	4 Missing and 2 partials ⚠️
github/enterprise_manage_ghes_maintenance.go	90.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
- Coverage   97.72%   92.29%   -5.43%     
==========================================
  Files         153      178      +25     
  Lines       13390    15273    +1883     
==========================================
+ Hits        13085    14096    +1011     
- Misses        215     1078     +863     
- Partials       90       99       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmlewis · 2025-01-15T20:14:59Z

Please run ./script/generate.sh and ./script/fmt.sh and push the changes to this PR. Thanks.

s4mur4i · 2025-01-15T21:23:06Z

Please run ./script/generate.sh and ./script/fmt.sh and push the changes to this PR. Thanks.

Strangely it doesn't show any diff for me:

➜  go-github git:(master) ./script/generate.sh                                                                
➜  go-github git:(master) ./script/fmt.sh                                                                     
➜  go-github git:(master) git status                                                                         
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

Even lint shows no diff:

➜  go-github git:(master) ./script/lint.sh                                                                   
linting .
linting example
linting scrape
linting tools
validating generated files

gmlewis · 2025-01-15T21:28:18Z

Can you see this? https://github.com/google/go-github/actions/runs/12794271004/job/35672748807?pr=3433

gmlewis

Thank you, @s4mur4i .

This is a very large PR, and it looks like there are going to be many things to address, so I'll stop my review here and hopefully we will get the linting issues worked out.

Please see CONTRIBUTING.md for more helpful information.

github/enterprise_manage_ghes.go

s4mur4i · 2025-01-15T21:52:01Z

Can you see this? https://github.com/google/go-github/actions/runs/12794271004/job/35672748807?pr=3433

Yes, I can. I don't really understand why I don't see change.

gmlewis · 2025-01-15T21:57:01Z

Can you see this? https://github.com/google/go-github/actions/runs/12794271004/job/35672748807?pr=3433

Yes, I can. I don't really understand why I don't see change.

One thing that I don't typically see in PRs is that you didn't create a separate branch for this change, but instead stayed on "master". I'm not sure if that is a problem or not, but it is one thing I don't think I've ever seen before. Typically, after you fork a repo and want to create a PR, you create a new branch and perform your work on that branch, then make a pull request off of that branch. Maybe this is nothing... I don't know... it's just different.

s4mur4i · 2025-01-15T22:04:21Z

Can you see this? https://github.com/google/go-github/actions/runs/12794271004/job/35672748807?pr=3433

Yes, I can. I don't really understand why I don't see change.

One thing that I don't typically see in PRs is that you didn't create a separate branch for this change, but instead stayed on "master". I'm not sure if that is a problem or not, but it is one thing I don't think I've ever seen before. Typically, after you fork a repo and want to create a PR, you create a new branch and perform your work on that branch, then make a pull request off of that branch. Maybe this is nothing... I don't know... it's just different.

I cloned in a new directory and worked. strange. but should be good now.

s4mur4i · 2025-01-16T14:46:34Z

@gmlewis Regarding generate. I dont know how to solve that issue.
I tried with one of my colleagues, and he has same output and behaviour.
I don't know if it might be because of mac-os.

gmlewis · 2025-01-16T14:55:44Z

@gmlewis Regarding generate. I dont know how to solve that issue. I tried with one of my colleagues, and he has same output and behaviour. I don't know if it might be because of mac-os.

Hmmm... very strange. I'm on a Mac too and have not seen this before.

s4mur4i · 2025-01-16T15:00:20Z

I reinstalled go o match exact version:

go-github git:(master) ✗ go version                                                                                                                                                           
go version go1.22.10 darwin/arm64

Pushed the update.

gmlewis · 2025-01-16T15:58:02Z

@stevehipwell - @alexandear - @dnwe - @willnorris - with our recently changes to Go Toolchain settings, we are now seeing bizarre problems like this one where the tooling did not help out the developer and made for a frustrating formatting experience. GitHub Workflows linting conflicted with the developer linting.

We need to come up with a solution that doesn't hurt the developer experience and yet is easy to maintain moving forward.

seruman · 2025-01-16T16:31:00Z

.. I tried with one of my colleagues, and he has same output and behaviour.

Colleague here! I've took a look at this and here're my findings;

SMTP struct has two fields; UserName and Username, looks like Github API returns both username and user_name 🤷

https://docs.github.com/enterprise-server@3.15/rest/enterprise-admin/manage-ghes#get-the-ghes-settings

https://github.com/s4mur4i/go-github/blob/a6383545144dd8f98845c94f4c453c920cb82046/github/enterprise_manage_ghes_config.go#L241-L242

The issue seems to be, for both fields getter.sortVal generated to has same value, lower case receiver + field;

go-github/github/gen-accessors.go

Line 221 in a638354

sortVal: strings.ToLower(receiverType) + "." + strings.ToLower(fieldName),

Since sort.Sort is not stable, it might sort these two getter's different on each run;

go-github/github/gen-accessors.go

Lines 184 to 185 in a638354

    
           // Sort getters by ReceiverType.FieldName. 
        
           sort.Sort(byName(t.Getters))

dnwe · 2025-01-16T16:33:35Z

@gmlewis I think #3436 is likely the required fix here

gmlewis · 2025-01-16T16:56:44Z

@s4mur4i - can you please manually make the changes from #3436 to this PR and see if that solves the problem for you?

s4mur4i · 2025-01-16T18:29:14Z

I accidently did a merge commit, just wanted to fix a resolve conflict :(
I applied the fixes from Pr #3436

gmlewis · 2025-01-16T19:26:38Z

I accidently did a merge commit, just wanted to fix a resolve conflict :( I applied the fixes from Pr #3436

No worries about the merge commit in this repo. We always squash-and-merge and therefore always have a clean commit history. This is also why we ask people to please not use force-push in this repo, as it makes it much more difficult for reviewers to see what has changed since their last review.

s4mur4i · 2025-01-16T21:26:16Z

As I see there is still lint error. I guess then the toolchain was not a fix for this case.

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

s4mur4i · 2025-01-17T07:32:40Z

I ran generate and fmt, lint shows no change for me. hopefully it is good now.
I rebased of master.

gmlewis

I have to step out of office for a while, but this review is taking a lot of time, so I will go ahead and give feedback on the one file I've looked at so far.
Please remember to not use force-push in this repo moving forward in order to save me review time for this large PR. Thanks.

github/enterprise_manage_ghes.go

gmlewis · 2025-01-17T14:10:50Z

github/enterprise_manage_ghes.go

+// ClusterStatus represents a response from the GetClusterStatus and GetReplicationStatus method.
+type ClusterStatus struct {
+	Status *string               `json:"status,omitempty"`
+	Nodes  []*ClusterStatusNodes `json:"nodes"`


Suggested change

Nodes []*ClusterStatusNodes `json:"nodes"`

Nodes []*ClusterStatusNode `json:"nodes"`

The reason I decided to go with Plural is that its an array, and would normally hold more nodes. The reason for the change would be that the struc defines a single Node and its more convention?

Fixed in d18f95d . PTAL

gmlewis · 2025-01-17T14:11:05Z

github/enterprise_manage_ghes.go

+// ClusterStatusNodes represents the status of a cluster node.
+type ClusterStatusNodes struct {


Suggested change

// ClusterStatusNodes represents the status of a cluster node.

type ClusterStatusNodes struct {

// ClusterStatusNode represents the status of a cluster node.

type ClusterStatusNode struct {

Fixed in d18f95d . PTAL

gmlewis · 2025-01-17T14:11:26Z

github/enterprise_manage_ghes.go

+type ClusterStatusNodes struct {
+	Hostname *string                       `json:"hostname,omitempty"`
+	Status   *string                       `json:"status,omitempty"`
+	Services []*ClusterStatusNodesServices `json:"services"`


Suggested change

Services []*ClusterStatusNodesServices `json:"services"`

Services []*ClusterStatusNodesService `json:"services"`

Following logic from previous review, wouldnt ClusterStatusNodeService to remove plural be better?

gmlewis · 2025-01-17T14:20:59Z

github/enterprise_manage_ghes.go

+	return replicationStatus, resp, nil
+}
+
+// Versions gets the versions information deployed to each node.


Suggested change

// Versions gets the versions information deployed to each node.

// Versions gets the version information deployed to each node.

Fixed in d18f95d . PTAL

gmlewis · 2025-01-17T14:21:43Z

github/enterprise_manage_ghes.go

+// GitHub API docs: https://docs.github.com/enterprise-server@3.15/rest/enterprise-admin/manage-ghes#get-all-ghes-release-versions-for-all-nodes
+//
+//meta:operation GET /manage/v1/version
+func (s *EnterpriseService) Versions(ctx context.Context, opts *NodeQueryOptions) ([]*NodeReleaseVersions, *Response, error) {


Suggested change

func (s *EnterpriseService) Versions(ctx context.Context, opts *NodeQueryOptions) ([]*NodeReleaseVersions, *Response, error) {

func (s *EnterpriseService) GetNodeReleaseVersions(ctx context.Context, opts *NodeQueryOptions) ([]*NodeReleaseVersion, *Response, error) {

One question here. Since we are returning a []*NodeReleaseVersion shouldn't name be GetNodeReleaseVersion?
We are returning version from each node, so if output is singular, shouldn't the API call be also singular?

No, because you get back a slice of zero or more versions returned.

Okay, than you. Fixed in d18f95d . PTAL

gmlewis · 2025-01-17T14:22:16Z

github/enterprise_manage_ghes.go

+// NodeReleaseVersions represents a response from the GetReplicationStatus method.
+type NodeReleaseVersions struct {


Suggested change

// NodeReleaseVersions represents a response from the GetReplicationStatus method.

type NodeReleaseVersions struct {

// NodeReleaseVersion represents a response from the GetNodeReleaseVersions method.

type NodeReleaseVersion struct {

Fixed in d18f95d . PTAL

gmlewis · 2025-01-17T14:22:58Z

github/enterprise_manage_ghes.go

+	Version  *ReleaseVersions `json:"version"`
+}
+
+// ReleaseVersions holds the release version information of the node.
+type ReleaseVersions struct {


Suggested change

Version *ReleaseVersions `json:"version"`

}

// ReleaseVersions holds the release version information of the node.

type ReleaseVersions struct {

Version *ReleaseVersion `json:"version"`

}

// ReleaseVersion holds the release version information of the node.

type ReleaseVersion struct {

Fixed in d18f95d . PTAL

gmlewis · 2025-01-17T14:23:55Z

github/enterprise_manage_ghes.go

+	Version   *string `json:"version,omitempty"`
+	Platform  *string `json:"platform,omitempty"`
+	BuildID   *string `json:"build_id,omitempty"`
+	BuildDate *string `json:"build_date,omitempty"`


Should this be *Timestamp instead of *string? I'll need to check the official docs, but don't have time right now.

@gmlewis it's a string in the following format 2023-05-02 (docs)

Yes, thats why I decided to use string. Dont know if Timestamp could have done a short date format.

stevehipwell · 2025-01-17T14:45:41Z

github/enterprise_manage_ghes_config.go

+type ConfigApplyStatus struct {
+	Running    *bool                     `json:"running,omitempty"`
+	Successful *bool                     `json:"successful,omitempty"`
+	Nodes      []*ConfigApplyStatusNodes `json:"nodes"`


Suggested change

Nodes []*ConfigApplyStatusNodes `json:"nodes"`

Nodes []*ConfigApplyStatusNode `json:"nodes"`

Fixed in c4121e9. PTAL

stevehipwell · 2025-01-17T14:46:10Z

github/enterprise_manage_ghes_config.go

+// ConfigApplyStatusNodes is a struct to hold the response from the ConfigApply API.
+type ConfigApplyStatusNodes struct {


Suggested change

// ConfigApplyStatusNodes is a struct to hold the response from the ConfigApply API.

type ConfigApplyStatusNodes struct {

// ConfigApplyStatusNode is a struct to hold the response from the ConfigApply API.

type ConfigApplyStatusNode struct {

Fixed in c4121e9. PTAL

stevehipwell · 2025-01-17T14:46:28Z

github/enterprise_manage_ghes_config.go

+
+// ConfigApplyEvents is a struct to hold the response from the ConfigApplyEvents API.
+type ConfigApplyEvents struct {
+	Nodes []*ConfigApplyEventsNodes `json:"nodes"`


Suggested change

Nodes []*ConfigApplyEventsNodes `json:"nodes"`

Nodes []*ConfigApplyEventsNode `json:"nodes"`

Fixed in c4121e9. PTAL

stevehipwell · 2025-01-17T14:46:49Z

github/enterprise_manage_ghes_config.go

+// ConfigApplyEventsNodes is a struct to hold the response from the ConfigApplyEvents API.
+type ConfigApplyEventsNodes struct {


Suggested change

// ConfigApplyEventsNodes is a struct to hold the response from the ConfigApplyEvents API.

type ConfigApplyEventsNodes struct {

// ConfigApplyEventsNode is a struct to hold the response from the ConfigApplyEvents API.

type ConfigApplyEventsNode struct {

Fixed in c4121e9. PTAL

stevehipwell · 2025-01-17T14:47:07Z

github/enterprise_manage_ghes_config.go

+type ConfigApplyEventsNodes struct {
+	Node          *string                        `json:"node,omitempty"`
+	LastRequestID *string                        `json:"last_request_id,omitempty"`
+	Events        []*ConfigApplyEventsNodeEvents `json:"events"`


Suggested change

Events []*ConfigApplyEventsNodeEvents `json:"events"`

Events []*ConfigApplyEventsNodeEvent `json:"events"`

Fixed in c4121e9. PTAL

stevehipwell · 2025-01-17T14:47:22Z

github/enterprise_manage_ghes_config.go

+// ConfigApplyEventsNodeEvents is a struct to hold the response from the ConfigApplyEvents API.
+type ConfigApplyEventsNodeEvents struct {


Suggested change

// ConfigApplyEventsNodeEvents is a struct to hold the response from the ConfigApplyEvents API.

type ConfigApplyEventsNodeEvents struct {

// ConfigApplyEventsNodeEvent is a struct to hold the response from the ConfigApplyEvents API.

type ConfigApplyEventsNodeEvent struct {

Fixed in c4121e9. PTAL

stevehipwell · 2025-01-17T14:49:12Z

github/enterprise_manage_ghes_maintenance.go

+	UUID                   *string               `json:"uuid,omitempty"`
+	Status                 *string               `json:"status,omitempty"`
+	ScheduledTime          *Timestamp            `json:"scheduled_time,omitempty"`
+	ConnectionServices     []*ConnectionServices `json:"connection_services"`


Suggested change

ConnectionServices []*ConnectionServices `json:"connection_services"`

ConnectionServices []*ConnectionService `json:"connection_services"`

stevehipwell · 2025-01-17T14:49:27Z

github/enterprise_manage_ghes_maintenance.go

+// ConnectionServices represents the connection services for the maintenance status.
+type ConnectionServices struct {


Suggested change

// ConnectionServices represents the connection services for the maintenance status.

type ConnectionServices struct {

// ConnectionService represents the connection services for the maintenance status.

type ConnectionService struct {

stevehipwell · 2025-01-17T14:49:58Z

github/enterprise_manage_ghes_ssh.go

+// ClusterSSHKeys represents the SSH keys configured for the instance.
+type ClusterSSHKeys struct {


Suggested change

// ClusterSSHKeys represents the SSH keys configured for the instance.

type ClusterSSHKeys struct {

// ClusterSSHKey represents the SSH keys configured for the instance.

type ClusterSSHKey struct {

Fixed in f3d10fd . PTAL

stevehipwell · 2025-01-17T14:52:06Z

@s4mur4i I added a few more review comments based on the ones in the file that @gmlewis had already covered.

s4mur4i · 2025-01-17T14:58:42Z

I have to step out of office for a while, but this review is taking a lot of time, so I will go ahead and give feedback on the one file I've looked at so far. Please remember to not use force-push in this repo moving forward in order to save me review time for this large PR. Thanks.

One question for myself. Contribution.md says not to use merge commit, but would say to do cherry-pick or rebase. I did a rebase to get the patch and to get latest state. but a rebase would require a force-push, I don't know of other way to do it.
Should I have just taken patch applied it manually, or is there any other method recommended?

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

stevehipwell · 2025-01-17T15:04:54Z

@s4mur4i I think @gmlewis prefers a merge on top of your branch.

gmlewis · 2025-01-17T16:49:59Z

One question for myself. Contribution.md says not to use merge commit, but would say to do cherry-pick or rebase. I did a rebase to get the patch and to get latest state. but a rebase would require a force-push, I don't know of other way to do it.
Should I have just taken patch applied it manually, or is there any other method recommended?

While you are working on a PR, you don't need to worry about what the master branch is doing.
Just keep pushing commits to your PR and please do NOT force-push.

We ALWAYS use "Squash and merge" in this repo, so our commit history is always clean. Do a "git log" on this repo to see what I mean.

If you ever have conflicting changes and GitHub says that the PR needs updating, you can simply follow these steps:

git checkout master
git pull origin master
git checkout my-custom-cool-branch-that-I-am-currently-working-on
git merge master

If there are conflicts, I personally like to use git mergetool (with kdiff3 as my merge tool) and resolve all the conflicts and then finalize the resolution with the command git commit -sam 'git merge master'.

git push origin my-custom-cool-branch-that-I-am-currently-working-on

This may add many commits to a PR, but in the end, it never matters because we always "Squash and merge".

Please let me know if any of this is not clear.

I tried to explain this clearly in CONTRIBUTING.md, but if it is still unclear, please send me a PR to clean up the wording so that it is super-easy to understand.
Thank you.

s4mur4i · 2025-01-17T19:38:41Z

@gmlewis I have an interesting issue, which I don't fully understand why.
I am working on 2 Comments. I have following Patch:

git diff github/enterprise_manage_ghes.go                                                                                                                                           cost-cluster
diff --git a/github/enterprise_manage_ghes.go b/github/enterprise_manage_ghes.go
index 3ecf373f..f4e136d8 100644
--- a/github/enterprise_manage_ghes.go
+++ b/github/enterprise_manage_ghes.go
@@ -27,13 +27,13 @@ type ClusterStatus struct {

 // ClusterStatusNode represents the status of a cluster node.
 type ClusterStatusNode struct {
-	Hostname *string                       `json:"hostname,omitempty"`
-	Status   *string                       `json:"status,omitempty"`
-	Services []*ClusterStatusNodesServices `json:"services"`
+	Hostname *string                      `json:"hostname,omitempty"`
+	Status   *string                      `json:"status,omitempty"`
+	Services []*ClusterStatusNodesService `json:"services"`
 }

-// ClusterStatusNodesServices represents the status of a service running on a cluster node.
-type ClusterStatusNodesServices struct {
+// ClusterStatusNodesService represents the status of a service running on a cluster node.
+type ClusterStatusNodesService struct {
 	Status  *string `json:"status,omitempty"`
 	Name    *string `json:"name,omitempty"`
 	Details *string `json:"details,omitempty"`

When I run generate I get following error:

./script/generate.sh                                                                                                                                                                cost-cluster
no operations defined for ClusterStatusNodesService.GetDetails
no operations defined for ClusterStatusNodesService.GetName
no operations defined for ClusterStatusNodesService.GetStatus
github/github.go:8: running "../script/metadata.sh": exit status 1

Same thing happens when I edit ConnectionService
Do you have idea why it might happen? All other generates were successful, just these 2 are having issues.
In github-accessors.go I see files successfully generated:

git diff github/github-accessors.go                                                                                                                                                 cost-cluster
diff --git a/github/github-accessors.go b/github/github-accessors.go
index d7841914..a020bcb4 100644
--- a/github/github-accessors.go
+++ b/github/github-accessors.go
@@ -2527,7 +2527,7 @@ func (c *ClusterStatusNode) GetStatus() string {
 }

 // GetDetails returns the Details field if it's non-nil, zero value otherwise.
-func (c *ClusterStatusNodesServices) GetDetails() string {
+func (c *ClusterStatusNodesService) GetDetails() string {
 	if c == nil || c.Details == nil {
 		return ""
 	}
@@ -2535,7 +2535,7 @@ func (c *ClusterStatusNodesServices) GetDetails() string {
 }

 // GetName returns the Name field if it's non-nil, zero value otherwise.
-func (c *ClusterStatusNodesServices) GetName() string {
+func (c *ClusterStatusNodesService) GetName() string {
 	if c == nil || c.Name == nil {
 		return ""
 	}
@@ -2543,7 +2543,7 @@ func (c *ClusterStatusNodesServices) GetName() string {
 }

 // GetStatus returns the Status field if it's non-nil, zero value otherwise.
-func (c *ClusterStatusNodesServices) GetStatus() string {
+func (c *ClusterStatusNodesService) GetStatus() string {
 	if c == nil || c.Status == nil {
 		return ""
 	}

Even stranger if I change it to ClusterStatusNodesServicess it works, and also ClusterStatusNodesServic works.

gmlewis · 2025-01-17T19:54:10Z

#3437 was just merged into master - can you please try it out to see if that fixes the problems you are seeing?

s4mur4i · 2025-01-17T20:07:54Z

#3437 was just merged into master - can you please try it out to see if that fixes the problems you are seeing?

This morning this got merged into my branch:
s4mur4i@d13c739
it is not working with it.

gmlewis · 2025-01-17T20:10:32Z

#3437 was just merged into master - can you please try it out to see if that fixes the problems you are seeing?

This morning this got merged into my branch: s4mur4i@d13c739 it is not working with it.

@alexandear - can you please comment?

alexandear · 2025-01-20T11:27:18Z

@gmlewis I have an interesting issue, which I don't fully understand why. I am working on 2 Comments. I have following Patch:
...

When I run generate I get following error:
./script/generate.sh                                                                                                                                                                cost-cluster
no operations defined for ClusterStatusNodesService.GetDetails
no operations defined for ClusterStatusNodesService.GetName
no operations defined for ClusterStatusNodesService.GetStatus
github/github.go:8: running "../script/metadata.sh": exit status 1
Same thing happens when I edit ConnectionService

Even stranger if I change it to ClusterStatusNodesServicess it works, and also ClusterStatusNodesServic works.

The issue appears because the struct suffixed with Service. It's because generate.sh executes metadata.sh, see

go-github/github/github.go

Line 8 in d13c739

//go:generate ../script/metadata.sh update-go

Every exported type where type name ends in Service, see

go-github/tools/metadata/metadata.go

Line 515 in d13c739

    
           if !id.IsExported() || !fn.Name.IsExported() || !strings.HasSuffix(id.Name, "Service") {

Service type is a special type in go-github for grouping related API functions. Examples: IssuesService, EnterpriseService etc.

To workaround this, we can rename ClusterStatusNodesServices to ClusterStatusNodesServiceItem, ConnectionServices to ConnectionServiceItem.

gmlewis changed the title ~~feat: Adding manage_ghes endpoints introduced in 3.15~~ feat: Add manage_ghes endpoints introduced in 3.15 Jan 15, 2025

gmlewis requested changes Jan 15, 2025

View reviewed changes

gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 15, 2025

alexandear mentioned this pull request Jan 16, 2025

gen-accessors: update dumping of getters #3437

Merged

s4mur4i and others added 9 commits January 17, 2025 10:20

Adding manage_ghes endpoints introduced in 3.15

b0d92eb

Fix year in Copyright

b0f90be

Fix generate & lint

e75c400

Fix double-space in comment

9a0776c

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix omitempty and types

c024efa

Fix ghes_ssh Modified field

65cea53

Fix broken test

519df01

Add missing testNewRequestAndDoFailure

cdb712e

Run generate

9775d73

s4mur4i added 3 commits January 17, 2025 10:20

Run generate

af473da

Run generate with go 1.22.0

f9aac39

Add google#3436 patch and generate

dfc158a

s4mur4i force-pushed the master branch from f701a7c to dfc158a Compare January 17, 2025 07:27

gmlewis requested changes Jan 17, 2025

View reviewed changes

stevehipwell reviewed Jan 17, 2025

View reviewed changes

s4mur4i and others added 2 commits January 17, 2025 18:00

Fix APIs

8eea7bb

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix plural of method in doc

885cafc

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>

Fix from review to enterprise_manage_ghes.go

d18f95d

s4mur4i added 2 commits January 17, 2025 22:18

Fix ClusterSSHKey

f3d10fd

Fix enterprise_manage_ghes_config

c4121e9

	Nodes []*ClusterStatusNodes `json:"nodes"`
	Nodes []*ClusterStatusNode `json:"nodes"`

		// ClusterStatusNodes represents the status of a cluster node.
		type ClusterStatusNodes struct {

	Services []*ClusterStatusNodesServices `json:"services"`
	Services []*ClusterStatusNodesService `json:"services"`

	// Versions gets the versions information deployed to each node.
	// Versions gets the version information deployed to each node.

	func (s EnterpriseService) Versions(ctx context.Context, opts NodeQueryOptions) ([]NodeReleaseVersions, Response, error) {
	func (s EnterpriseService) GetNodeReleaseVersions(ctx context.Context, opts NodeQueryOptions) ([]NodeReleaseVersion, Response, error) {

		// NodeReleaseVersions represents a response from the GetReplicationStatus method.
		type NodeReleaseVersions struct {

	Nodes []*ConfigApplyStatusNodes `json:"nodes"`
	Nodes []*ConfigApplyStatusNode `json:"nodes"`

		// ConfigApplyStatusNodes is a struct to hold the response from the ConfigApply API.
		type ConfigApplyStatusNodes struct {

	Nodes []*ConfigApplyEventsNodes `json:"nodes"`
	Nodes []*ConfigApplyEventsNode `json:"nodes"`

		// ConfigApplyEventsNodes is a struct to hold the response from the ConfigApplyEvents API.
		type ConfigApplyEventsNodes struct {

	Events []*ConfigApplyEventsNodeEvents `json:"events"`
	Events []*ConfigApplyEventsNodeEvent `json:"events"`

		// ConfigApplyEventsNodeEvents is a struct to hold the response from the ConfigApplyEvents API.
		type ConfigApplyEventsNodeEvents struct {

	ConnectionServices []*ConnectionServices `json:"connection_services"`
	ConnectionServices []*ConnectionService `json:"connection_services"`

		// ConnectionServices represents the connection services for the maintenance status.
		type ConnectionServices struct {

		// ClusterSSHKeys represents the SSH keys configured for the instance.
		type ClusterSSHKeys struct {

feat: Add manage_ghes endpoints introduced in 3.15 #3433

Are you sure you want to change the base?

feat: Add manage_ghes endpoints introduced in 3.15 #3433

Conversation

s4mur4i commented Jan 15, 2025

codecov bot commented Jan 15, 2025 • edited Loading

Codecov Report

gmlewis commented Jan 15, 2025

s4mur4i commented Jan 15, 2025

gmlewis commented Jan 15, 2025

gmlewis left a comment

Choose a reason for hiding this comment

s4mur4i commented Jan 15, 2025

gmlewis commented Jan 15, 2025

s4mur4i commented Jan 15, 2025

s4mur4i commented Jan 16, 2025

gmlewis commented Jan 16, 2025

s4mur4i commented Jan 16, 2025

gmlewis commented Jan 16, 2025

seruman commented Jan 16, 2025 • edited Loading

dnwe commented Jan 16, 2025

gmlewis commented Jan 16, 2025

s4mur4i commented Jan 16, 2025

gmlewis commented Jan 16, 2025

s4mur4i commented Jan 16, 2025

s4mur4i commented Jan 17, 2025

gmlewis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevehipwell commented Jan 17, 2025

s4mur4i commented Jan 17, 2025

stevehipwell commented Jan 17, 2025

gmlewis commented Jan 17, 2025 • edited Loading

s4mur4i commented Jan 17, 2025 • edited Loading

gmlewis commented Jan 17, 2025

s4mur4i commented Jan 17, 2025

gmlewis commented Jan 17, 2025

alexandear commented Jan 20, 2025 • edited Loading

codecov bot commented Jan 15, 2025 •

edited

Loading

seruman commented Jan 16, 2025 •

edited

Loading

gmlewis commented Jan 17, 2025 •

edited

Loading

s4mur4i commented Jan 17, 2025 •

edited

Loading

alexandear commented Jan 20, 2025 •

edited

Loading