Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the error of illegal memory access caused by cub #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShunChengWu
Copy link

Fix an issue caused by cub.
From my own test, the problem happened when you call cub related functions, such as InclusiveSum Here https://github.com/graphdeco-inria/diff-gaussian-rasterization/blob/main/cuda_rasterizer/rasterizer_impl.cu#L281.
The problem is that the copy process does not go all the way. From my test, the copy somehow stopped at around 80K. After I tried to bypass that function by using std::inclusive_scan. However, illegal memory access happened somewhere in the backward pass.
Afterward, I found that a similar issue kind of happened in custom-built Pytorch functions (NVIDIA/thrust#1341) and found the solution here pytorch/pytorch#52663 (comment).

After the test, I used the modified code to train Gaussian Splatting on the Blender Lego dataset, and it worked like a charm.

Related issues:

@hyqlat

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants