Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hop) #518

Merged
merged 34 commits into from
Dec 5, 2023
Merged

fix(hop) #518

merged 34 commits into from
Dec 5, 2023

Conversation

lmeyerov
Copy link
Contributor

@lmeyerov lmeyerov commented Dec 1, 2023

fix handling of source_node_match attributes in hop()

assert g3a._nodes.shape == (2, 2)
assert g3a._edges.shape == (1, 3)

#TODO investigate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create some GH issues some this TODO and the next one?

@lmeyerov lmeyerov merged commit 32f4d14 into master Dec 5, 2023
38 checks passed
@lmeyerov lmeyerov deleted the dev/fix-hop branch December 5, 2023 08:00
@lmeyerov lmeyerov restored the dev/fix-hop branch December 5, 2023 08:00
@lmeyerov lmeyerov deleted the dev/fix-hop branch December 5, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants