Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isAcyclic function in the GraphProperty class #38

Open
wants to merge 2 commits into
base: 0.9.x
Choose a base branch
from

Conversation

Gillu13
Copy link

@Gillu13 Gillu13 commented Jan 29, 2020

I added an "isAcyclic" function in the GraphProperty class + some unit tests. Hope this was the right place to add this.

@Gillu13
Copy link
Author

Gillu13 commented Jan 30, 2020

OK, I need to change the array declaration to be complient with php 5.3

@clue
Copy link
Member

clue commented Feb 19, 2020

@Gillu13 Thank you for filing this PR 👍 It looks like this might be better off in a separate class (see also #33) and this should probably be tested against more graphs (i.e. empty, edgeless, loop edges etc.), is this something you're planning to look into?

I'd first like to get a maintenance release out to bring this library up to date before introducing any additional algorithms. Once this is done, I'm looking forward to merging more of these algorithms, so I hope you're still interested in getting this merged then :shipit:

Again thank you for your valuable contribution! I understand this long wait time can be frustrating, so rest assured I'll try to get these intermediary release out as soon as time permits (this project doesn't currently get any sponsoring, so this happens mostly in my spare free time) and will then look into this PR again in more depth! 👍

@Gillu13
Copy link
Author

Gillu13 commented Feb 24, 2020

Sounds good! cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants