Implement tracked radios cache #928
Conversation
…the middle of streaming
kurotych
requested review from
bbalser,
andymck,
jeffgrunewald and
michaeldjeffrey
mobile_config/src/gateway_service.rs
Outdated
| @@ -241,18 +240,17 @@ impl mobile_config::Gateway for GatewayService { | |||
|
|
|||
| let (tx, rx) = tokio::sync::mpsc::channel(100); | |||
|
|
|||
| let radios_cache = Arc::clone(&self.tracked_radios_cache); | |||
There was a problem hiding this comment.
self.tracked_radios_cache is already an Arc, you should be able to just self.tracked_radios_cache.clone() no?
There was a problem hiding this comment.
Arc::clone(...) and self.tracked_radios_cache.clone() are actually the same under the hood.
When I use Arc::clone I just want to emphasize (clarity) in the code that it clones the reference (not the value).
Since it is not crucial for me, I've replaced as you ask
| pub async fn get_updated_radios( | ||
| pool: &Pool<Postgres>, | ||
| min_updated_at: DateTime<Utc>, | ||
| ) -> anyhow::Result<HashMap<PublicKeyBinary, DateTime<Utc>>> { |
There was a problem hiding this comment.
| ) -> anyhow::Result<HashMap<PublicKeyBinary, DateTime<Utc>>> { | |
| ) -> anyhow::Result<TrackedRadiosMap> { |
|
|
||
| pub type TrackedRadiosMap = HashMap<PublicKeyBinary, DateTime<Utc>>; |
There was a problem hiding this comment.
I'm wondering if this would make sense as it's own type
#[derive(Clone)]
pub struct TrackedRadiosMap(Arc<RwLock<HashMap<PublicKeyBinary, DateTime<Utc>>>);We would get Clone for free.
And we could hang methods like get_updated_radios off of it, and it would self update.
And other access methods could manage the read locking instead of the user.
Just thinking out loud.
The cache updates each time mobile tracker runs