-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(build): Use WebWorker when removing private fields #3821
Conversation
b71e8cc
to
6807d43
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3821 +/- ##
==========================================
- Coverage 91.71% 91.30% -0.41%
==========================================
Files 160 161 +1
Lines 10195 10241 +46
Branches 2885 2848 -37
==========================================
+ Hits 9350 9351 +1
- Misses 844 889 +45
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Hi @miyaji255 This is super cool! I've tried it, and it's working very fast on my machine. I love this change. @nakasyou Can you review this PR? |
Yes but about a day please🙏 |
@nakasyou No problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! Check my review.
Co-authored-by: Shotaro Nakamura <79000684+nakasyou@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your great work! Merging. |
removePrivateFields
is a heavy CPU-bound process. This PR improves performance by using all CPU in WebWorker.The following is the
removePrivateFields
time for the current build process.Environemt:
Current: 47750.3256ms
This PR: 10963.4007ms
The Github Actions environment is 4 CPUs, so CI may not improve performance that much. I think it will be very fast in local environment.