Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems to this library works well with plain react-native project not expo only.
Could we remove expo peer dependency in package.json?
Also, I configure some typo, dependencies in project.
Works
expo
from peer dependenciessource.fixAll
typetrue
toexplicit
(recommended by vscode)The current project's jest test is broken. We meet this error.
This is resolved by bumping jest to
^29.7.0
If user set
source.organizeImports
asalways
orexplicit
in their usersettings.json
, then the import order will be mixed on save during development.We can enforce this by declare it in project settings.
Related Issues
expo
as a peer dependency is causing warnings #60Tests
None
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.yarn lint && yarn tsc
yarn test
oryarn test -u
if you need to update snapshot.