Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tagFilter setting #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

diranged
Copy link

This PR introduces a new tagFilter setting that allows users to filter out tags from the version checking logic. In our particular case, we have semver tags like v1.2.4 and then we have auto-generated tags named v1.2.4-chart. This was causing the SemVer action logic to fail:

Run ietf-tools/semver-action@v1
Comparing against latest tag: v1.2.4-chart
[PATCH] ...

>>> Will bump version v1.2.4-chart using PATCH

Current version is v1.2.4-chart
Next version is v1.2.4

With this new setting in place, I can set tagFilter: (.+)-(chart) and then it filters that tag out and we get the next version we expect:

Run diranged/semver-action@filter
Will filter out tags that match: (.+)-(chart)
Skipping tag "v1.2.4-chart" (matches tagFilter)
Comparing against latest tag: v1.2.4
[PATCH] ...

>>> Will bump version v1.2.4 using PATCH

Current version is v1.2.4
Next version is v1.2.5

@diranged
Copy link
Author

@NGPixel,
What do you think of this change?

@diranged
Copy link
Author

@NGPixel Ping?

@diranged
Copy link
Author

Or @christian-draeger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant