Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced defaultProps with destructuring and updated the snapshots #2598

Closed
wants to merge 3 commits into from
Closed

Replaced defaultProps with destructuring and updated the snapshots #2598

wants to merge 3 commits into from

Conversation

its-me-abhishek
Copy link

@its-me-abhishek its-me-abhishek commented Jan 19, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Removed defaultProps from the components wherever possible to comply with modern React standards and TypeScript best practices.
  • Updated snapshots in tests to align with the updated implementation.

How was this change tested?

  • Running npm run update-snapshots and npm test passes all tests

Checklist

@its-me-abhishek
Refactor defaultProp
6b7e09e 
Updated defaultProps to use destructuring to avoid deprecation. Snapshots have been updated to match the changes. Resolves jaegertracing#2596.

Signed-off-by: Abhishek <bumblebee31304@gmail.com>
@its-me-abhishek
Fix consistency issues across components
d9bbda9 
Resolves jaegertracing#2596 Updated the components to fix broken working.

Signed-off-by: Abhishek <bumblebee31304@gmail.com>
@its-me-abhishek its-me-abhishek requested a review from a team as a code owner January 19, 2025 10:03
@its-me-abhishek its-me-abhishek requested review from albertteoh and removed request for a team January 19, 2025 10:03
@its-me-abhishek
Remove defaultProps from ScatterPlot
ae97ac7 
Resolves jaegertracing#2596 Updated the ScatterPlot component to remove defaultProps

Signed-off-by: Abhishek <bumblebee31304@gmail.com>
yurishkuro
yurishkuro requested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to review this PR, it's too large. Please pick an individual component and make changes in a small PR.

@its-me-abhishek
Copy link
Author

Sure, closing this PR, will create a new one for a single component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro requested changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Support for defaultProps in Function Components to be Removed
2 participants
@its-me-abhishek @yurishkuro