Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced defaultProps with destructuring and updated the snapshots #2598

Closed
wants to merge 3 commits into from
Closed

Replaced defaultProps with destructuring and updated the snapshots #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b7e09e
Refactor defaultProp
its-me-abhishek Jan 19, 2025
d9bbda9
Fix consistency issues across components
its-me-abhishek Jan 19, 2025
ae97ac7
Remove defaultProps from ScatterPlot
its-me-abhishek Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 10 additions & 48 deletions ...-ui/src/components/DeepDependencies/Graph/DdgNodeContent/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ exports[`<DdgNodeContent> omits the operation if it is null 1`] = `
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -96,7 +95,6 @@ exports[`<DdgNodeContent> omits the operation if it is null 1`] = `
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -155,9 +153,7 @@ exports[`<DdgNodeContent> omits the operation if it is null 1`] = `
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -232,7 +228,6 @@ exports[`<DdgNodeContent> omits the operation if it is null 2`] = `
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -291,9 +286,7 @@ exports[`<DdgNodeContent> omits the operation if it is null 2`] = `
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -368,7 +361,6 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 1`]
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -383,7 +375,6 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 1`]
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -442,9 +433,7 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 1`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -519,7 +508,6 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 2`]
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -534,7 +522,6 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 2`]
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -593,9 +580,7 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 2`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -670,7 +655,6 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 1`]
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -685,7 +669,6 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 1`]
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -744,9 +727,7 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 1`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -824,7 +805,6 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 2`]
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -839,7 +819,6 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 2`]
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -898,9 +877,7 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 2`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -975,7 +952,6 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -990,7 +966,6 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -1049,9 +1024,7 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -1126,7 +1099,6 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -1141,7 +1113,6 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -1159,9 +1130,7 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -1204,7 +1173,6 @@ exports[`<DdgNodeContent> renders the number of operations if there are multiple
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand All @@ -1219,7 +1187,6 @@ exports[`<DdgNodeContent> renders the number of operations if there are multiple
}
>
<BreakableText
className="BreakableText"
text="some-operation"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -1278,9 +1245,7 @@ exports[`<DdgNodeContent> renders the number of operations if there are multiple
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -1355,7 +1320,6 @@ exports[`<DdgNodeContent> renders the number of operations if there are multiple
}
>
<BreakableText
className="BreakableText"
text="some-service"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
Expand Down Expand Up @@ -1446,9 +1410,7 @@ exports[`<DdgNodeContent> renders the number of operations if there are multiple
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down
26 changes: 1 addition & 25 deletions ...eger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ exports[`<SidePanel> render renders 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand Down Expand Up @@ -53,9 +51,7 @@ exports[`<SidePanel> render renders detailLink 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand All @@ -74,9 +70,7 @@ exports[`<SidePanel> render renders detailLink 1`] = `
rel="noreferrer noopener"
target="_blank"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</Tooltip>
</div>
Expand All @@ -89,9 +83,7 @@ exports[`<SidePanel> render renders detailLink 1`] = `
className="Ddg--DetailsPanel--LoadingWrapper"
>
<LoadingIndicator
centered={false}
className="Ddg--DetailsPanel--LoadingIndicator"
small={false}
/>
</div>
<VerticalResizer
Expand All @@ -117,9 +109,7 @@ exports[`<SidePanel> render renders details 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand Down Expand Up @@ -162,9 +152,7 @@ exports[`<SidePanel> render renders details error 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand Down Expand Up @@ -207,9 +195,7 @@ exports[`<SidePanel> render renders omitted array of operations 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand Down Expand Up @@ -247,9 +233,7 @@ exports[`<SidePanel> render renders while loading 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand All @@ -268,9 +252,7 @@ exports[`<SidePanel> render renders while loading 1`] = `
className="Ddg--DetailsPanel--LoadingWrapper"
>
<LoadingIndicator
centered={false}
className="Ddg--DetailsPanel--LoadingIndicator"
small={false}
/>
</div>
<VerticalResizer
Expand All @@ -296,14 +278,10 @@ exports[`<SidePanel> render renders with operation 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
<BreakableText
className="BreakableText"
text="::test op"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand Down Expand Up @@ -341,9 +319,7 @@ exports[`<SidePanel> render renders with progressbar 1`] = `
className="Ddg--DetailsPanel--SvcOpHeader"
>
<BreakableText
className="BreakableText"
text="test svc"
wordRegexp={/\\\\W\\*\\\\w\\+\\\\W\\*/g}
/>
</div>
<div
Expand Down
Loading