Remove mention of non-existent "session" option #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree @JamesMGreene came here just to check if |
|
@jaredhanson I ran into this issue as well. Any chance to merge this PR? |
|
ping @jaredhanson |
rwky
added a commit
to passport-next/passport-local
that referenced
this pull request
Jul 7, 2018
|
I too was really confused by the session-option in the documentation. @jaredhanson is it possible to merge this into the main-library? Or is it perhaps recommended to adopt the usage of passport-next where this fix was merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README makes some references to an option called
"session"that were added in commit 06d290bThe codebase does not contain any such option today, nor did it at the time of that commit (i.e. if you look at https://github.com/jaredhanson/passport-local/tree/06d290bf07c5cfcff1ef72cba8edc93bc6ca9cbc ).
This was confusing for me... probably for others as well.