forked from carlos22/carddav2fb
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust config.example.php for better international area code conversion #49
Open
obnys
wants to merge
174
commits into
jens-maus:master
Choose a base branch
from
andig:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding information from testteam
Preparations for launch
* replace redundant login code with function * split exportPhonebook in conversion to contacts and XML phonebook assembly
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version. - [Release notes](https://github.com/guzzle/guzzle/releases) - [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md) - [Commits](guzzle/guzzle@6.0.0...7.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Escape HTML entities in email addresses
Fixing VIP attribute examples in config.example.php
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the international area code '+49' is beeing replaced with nothing '' by default at the config.example.php:
I'd suggest to replace this entry with the following lines in order to keep the phone number intact by default. Otherwise the area code of the phone number would miss the leading '0'
As for non-german users (no idea, how big the user community is), it might be even better to define the local international area code in some kind of a variable at the top of the config.example.php. If this entry stays empty, the program could assume let's say for example Germany for the local international area code. I have no idea about that program language, but in Linux style, it might look like this:
BUT: What I'm not sure about is how to prevent the config from replacing the number, let's say 0049, in the middle of a number like 012334 / 90049123454. Would it be possible to inspect the beginning of a string? Like in Linux you would use