Allow Type Dispatch on Functions Using AlphaZero.Trainer #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbriquse
changed the title
umbriquse
changed the title
umbriquse
changed the title
|
This is a good suggestion, thanks! |
|
Will the next version be a completely new package, or a branch/fork that will eventually be merged? |
|
It will be a branch that will be merged. I haven't started working on it yet but I am writing down some ideas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across a use case where I need to change the functionality for batch_updates!, learning_status, and some more functions. I currently just overload the function itself, causing a warning during compilation of my package. It would be ideal if I can perform type dispatch to use the custom functions instead of overloading your functions.