feat: Add facets filtering for Incidents #3060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor facet properties to use snake_case
…efactor related components for improved data handling
…ls and UI components for facet management
… at end of file in create_facet function
…e IncidentList component to accept initial facets data
…ce PropertiesMetadata for better property handling
…efinitions for facet options
… mark static facets as true
…m/keephq/keep into 2910-cel-filtering-for-incidents_
…m/keephq/keep into 2910-cel-filtering-for-incidents_
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
- Coverage 43.06% 42.32% -0.74%
==========================================
Files 166 182 +16
Lines 16685 17905 +1220
==========================================
+ Hits 7186 7579 +393
- Misses 9499 10326 +827 ☔ View full report in Codecov by Sentry. |
- Updated facet-panel-server-side.tsx to enhance filtering logic - Refactored facet.tsx for better performance - Improved facets-panel.tsx to support new filtering features - Enhanced incident-list.tsx to display filtered incidents correctly - Updated useIncidents.ts to integrate new filtering logic
…pe in PostgreSQL provider
… improve error handling in CelToAstConverter
…ldsNode, PropertiesMappingException, and PropertiesMapper classes
dosubot
bot
added
the
size:XXL
dosubot
bot
added
Documentation
shahargl
reviewed
Jan 20, 2025
| @@ -0,0 +1,21 @@ | |||
| """empty message | |||
There was a problem hiding this comment.
You mean the message or migration itself?
This is conflict-solving migration version mine and from main
I can add better message instead of "ëmpty message"
shahargl
reviewed
Jan 20, 2025
| @@ -0,0 +1,130 @@ | |||
|
|
|||
There was a problem hiding this comment.
add docs about this moduel and what it does
…m/keephq/keep into 2910-cel-filtering-for-incidents_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2910
📑 Description
✅ Checks
ℹ Additional Information