Feat/action linter (#10466)

Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com>

.github/workflows/composite-actions/kube-gateway-api-conformance-tests/action.yaml → .github/actions/kube-gateway-api-conformance-tests/action.yaml

@@ -4,7 +4,7 @@ runs:
   using: "composite"
   steps:
   - name: Prep Go Runner
-    uses: ./.github/workflows/composite-actions/prep-go-runner
+    uses: ./.github/actions/prep-go-runner
   - name: Install kind
     uses: helm/kind-action@v1.10.0
     with:

.github/workflows/composite-actions/regression-tests/action.yaml → .github/actions/regression-tests/action.yaml

@@ -6,7 +6,7 @@ runs:
   using: "composite"
   steps:
   - name: Prep Go Runner
-    uses: ./.github/workflows/composite-actions/prep-go-runner
+    uses: ./.github/actions/prep-go-runner
   - name: Install kind
     uses: helm/kind-action@v1.10.0
     with:

.github/workflows/action_lint.yaml

@@ -0,0 +1,22 @@
+name: pr-github-workflow-lint
+
+on:
+  pull_request:
+    paths:
+      - .github/*.yaml
+      - .github/*.yml
+permissions:
+  contents: read
+
+jobs:
+  actionlint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          sparse-checkout: .github
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: 'go.mod'
+      - run: go install github.com/rhysd/actionlint/cmd/actionlint@v1.7.6
+      - run: actionlint

.github/workflows/cache-setup.yaml

@@ -16,4 +16,4 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v4
     - name: Prep Go Runner
-      uses: ./.github/workflows/composite-actions/prep-go-runner
+      uses: ./.github/actions/prep-go-runner

.github/workflows/conformance-tests.yaml

@@ -38,7 +38,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Run Conformance Tests
-        uses: ./.github/workflows/composite-actions/kube-gateway-api-conformance-tests
+        uses: ./.github/actions/kube-gateway-api-conformance-tests
 
       # TODO(tim): Add support for downloading the test results and creating
       # a pull request whenever a new release > 1.17+ is cut.

.github/workflows/nightly-tests.yaml

@@ -90,11 +90,11 @@ jobs:
           path: ${{ matrix.version-files.file }}
           log-variables: true
       - name: Prep Go Runner
-        uses: ./.github/workflows/composite-actions/prep-go-runner
+        uses: ./.github/actions/prep-go-runner
       # Set up the KinD cluster that the tests will use
       - id: setup-kind-cluster
         name: Setup KinD Cluster
-        uses: ./.github/workflows/composite-actions/setup-kind-cluster
+        uses: ./.github/actions/setup-kind-cluster
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           kind-node-version: ${{ steps.dotenv.outputs.node_version }}
@@ -106,7 +106,7 @@ jobs:
       # Run the tests
       - id: run-tests
         name: Run Kubernetes e2e Tests
-        uses: ./.github/workflows/composite-actions/kubernetes-e2e-tests
+        uses: ./.github/actions/kubernetes-e2e-tests
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           test-args: ${{ matrix.test.go-test-args }}
@@ -152,11 +152,11 @@ jobs:
           path: ${{ matrix.version-files.file }}
           log-variables: true
       - name: Prep Go Runner
-        uses: ./.github/workflows/composite-actions/prep-go-runner
+        uses: ./.github/actions/prep-go-runner
       # Set up the KinD cluster that the tests will use
       - id: setup-kind-cluster
         name: Setup KinD Cluster
-        uses: ./.github/workflows/composite-actions/setup-kind-cluster
+        uses: ./.github/actions/setup-kind-cluster
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           kind-node-version: ${{ steps.dotenv.outputs.node_version }}
@@ -168,7 +168,7 @@ jobs:
       # Run the tests
       - id: run-tests
         name: Run Kubernetes e2e Tests
-        uses: ./.github/workflows/composite-actions/kubernetes-e2e-tests
+        uses: ./.github/actions/kubernetes-e2e-tests
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           test-args: ${{ matrix.test.go-test-args }}
@@ -215,11 +215,11 @@ jobs:
           path: ${{ matrix.version-files.file }}
           log-variables: true
       - name: Prep Go Runner
-        uses: ./.github/workflows/composite-actions/prep-go-runner
+        uses: ./.github/actions/prep-go-runner
       # Set up the KinD cluster that the tests will use
       - id: setup-kind-cluster
         name: Setup KinD Cluster
-        uses: ./.github/workflows/composite-actions/setup-kind-cluster
+        uses: ./.github/actions/setup-kind-cluster
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           kind-node-version: ${{ steps.dotenv.outputs.node_version }}
@@ -231,7 +231,7 @@ jobs:
       # Run the tests
       - id: run-tests
         name: Run Kubernetes e2e Tests
-        uses: ./.github/workflows/composite-actions/kubernetes-e2e-tests
+        uses: ./.github/actions/kubernetes-e2e-tests
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           test-args: ${{ matrix.test.go-test-args }}
@@ -277,11 +277,11 @@ jobs:
           path: ${{ matrix.version-files.file }}
           log-variables: true
       - name: Prep Go Runner
-        uses: ./.github/workflows/composite-actions/prep-go-runner
+        uses: ./.github/actions/prep-go-runner
       # Set up the KinD cluster that the tests will use
       - id: setup-kind-cluster
         name: Setup KinD Cluster
-        uses: ./.github/workflows/composite-actions/setup-kind-cluster
+        uses: ./.github/actions/setup-kind-cluster
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           kind-node-version: ${{ steps.dotenv.outputs.node_version }}
@@ -292,7 +292,7 @@ jobs:
       # Run the tests
       - id: run-tests
         name: Run Kubernetes e2e Tests
-        uses: ./.github/workflows/composite-actions/kubernetes-e2e-tests
+        uses: ./.github/actions/kubernetes-e2e-tests
         with:
           cluster-name: ${{ matrix.test.cluster-name }}
           test-args: ${{ matrix.test.go-test-args }}
@@ -317,7 +317,7 @@ jobs:
     - uses: actions/checkout@v4
       with:
         ref: ${{ github.ref_name }}
-    - uses: ./.github/workflows/composite-actions/regression-tests
+    - uses: ./.github/actions/regression-tests
 
   regression_tests_main:
     name: main regression tests
@@ -346,7 +346,7 @@ jobs:
     - uses: actions/checkout@v4
       with:
         ref: main
-    - uses: ./.github/workflows/composite-actions/regression-tests
+    - uses: ./.github/actions/regression-tests
 
   regression_tests_18:
     name: v1.18.x regression tests
@@ -375,7 +375,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.18.x
-      - uses: ./.github/workflows/composite-actions/regression-tests
+      - uses: ./.github/actions/regression-tests
 
 
   regression_tests_17:
@@ -394,7 +394,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.17.x
-      - uses: ./.github/workflows/composite-actions/regression-tests
+      - uses: ./.github/actions/regression-tests
 
   regression_tests_16:
     name: v1.16.x regression tests
@@ -411,7 +411,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.16.x
-      - uses: ./.github/workflows/composite-actions/regression-tests
+      - uses: ./.github/actions/regression-tests
 
   performance_tests_on_demand:
     name: on demand performance tests
@@ -422,8 +422,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: ${{ github.ref_name }}
-      - uses: ./.github/workflows/composite-actions/prep-go-runner
-      - uses: ./.github/workflows/composite-actions/performance-tests
+      - uses: ./.github/actions/prep-go-runner
+      - uses: ./.github/actions/performance-tests
 
   performance_tests_main:
     name: main performance tests
@@ -434,8 +434,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: main
-      - uses: ./.github/workflows/composite-actions/prep-go-runner
-      - uses: ./.github/workflows/composite-actions/performance-tests
+      - uses: ./.github/actions/prep-go-runner
+      - uses: ./.github/actions/performance-tests
 
   performance_tests_18:
     name: v1.18.x performance tests
@@ -446,8 +446,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.18.x
-      - uses: ./.github/workflows/composite-actions/prep-go-runner
-      - uses: ./.github/workflows/composite-actions/performance-tests
+      - uses: ./.github/actions/prep-go-runner
+      - uses: ./.github/actions/performance-tests
 
   performance_tests_17:
     name: v1.17.x performance tests
@@ -458,8 +458,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.17.x
-      - uses: ./.github/workflows/composite-actions/prep-go-runner
-      - uses: ./.github/workflows/composite-actions/performance-tests
+      - uses: ./.github/actions/prep-go-runner
+      - uses: ./.github/actions/performance-tests
 
   performance_tests_16:
     name: v1.16.x performance tests
@@ -470,8 +470,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.16.x
-      - uses: ./.github/workflows/composite-actions/prep-go-runner
-      - uses: ./.github/workflows/composite-actions/performance-tests
+      - uses: ./.github/actions/prep-go-runner
+      - uses: ./.github/actions/performance-tests
 
   kube_gateway_api_conformance_tests_main:
     name: Conformance (branch=main, type=Kubernetes Gateway API, version=${{matrix.kube-version.node}} )
@@ -489,7 +489,7 @@ jobs:
     - uses: actions/checkout@v4
       with:
         ref: main
-    - uses: ./.github/workflows/composite-actions/kube-gateway-api-conformance-tests
+    - uses: ./.github/actions/kube-gateway-api-conformance-tests
 
   kube_gateway_api_conformance_tests_18:
     name: Conformance (branch=v1.18.x, type=Kubernetes Gateway API, version=${{matrix.kube-version.node}} )
@@ -507,7 +507,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.18.x
-      - uses: ./.github/workflows/composite-actions/kube-gateway-api-conformance-tests
+      - uses: ./.github/actions/kube-gateway-api-conformance-tests
 
 
   kube_gateway_api_conformance_tests_17:
@@ -526,7 +526,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: v1.17.x
-      - uses: ./.github/workflows/composite-actions/kube-gateway-api-conformance-tests
+      - uses: ./.github/actions/kube-gateway-api-conformance-tests
 
   publish_results:
     runs-on: ubuntu-22.04

.github/workflows/pr-kubernetes-tests.yaml → .github/workflows/pr-kubernetes-tests.yaml_noop

@@ -26,7 +26,7 @@
 #         # which compares the state of two branches
 #         fetch-depth: 0
 #     - id: process-skip-directives
-#       uses: ./.github/workflows/composite-actions/process-skip-directives
+#       uses: ./.github/actions/process-skip-directives
 #       with:
 #         base-ref: ${{ github.base_ref }}
 #     - id: run-strategy
@@ -101,7 +101,7 @@
 #         echo "Regression tests auto-succeeded"
 #     - uses: actions/checkout@v4
 #     - name: Prep Go Runner
-#       uses: ./.github/workflows/composite-actions/prep-go-runner
+#       uses: ./.github/actions/prep-go-runner
 #       if: needs.prepare_env.outputs.should-auto-succeed-kube-tests != 'true'
 #     # The dotenv action is used to load key-value pairs from files.
 #     # In this case, the file is specified in the matrix and will contain the versions of the tools to use
@@ -115,7 +115,7 @@
 #     - id: setup-kind-cluster
 #       name: Setup KinD Cluster
 #       if: needs.prepare_env.outputs.should-auto-succeed-kube-tests != 'true'
-#       uses: ./.github/workflows/composite-actions/setup-kind-cluster
+#       uses: ./.github/actions/setup-kind-cluster
 #       with:
 #         cluster-name: ${{ matrix.test.cluster-name }}
 #         kind-node-version: ${{ steps.dotenv.outputs.node_version }}
@@ -125,7 +125,7 @@
 #         istio-version: ${{ steps.dotenv.outputs.istio_version }}
 #     - id: run-tests
 #       if: needs.prepare_env.outputs.should-auto-succeed-kube-tests != 'true'
-#       uses: ./.github/workflows/composite-actions/kubernetes-e2e-tests
+#       uses: ./.github/actions/kubernetes-e2e-tests
 #       with:
 #         cluster-name: ${{ matrix.test.cluster-name }}
 #         test-args: ${{ matrix.test.go-test-args }}

.github/workflows/regression-tests.yaml

@@ -28,7 +28,7 @@ jobs:
         # which compares the state of two branches
         fetch-depth: 0
     - id: process-skip-directives
-      uses: ./.github/workflows/composite-actions/process-skip-directives
+      uses: ./.github/actions/process-skip-directives
       with:
         base-ref: ${{ github.base_ref }}
     - id: run-strategy
@@ -64,7 +64,7 @@ jobs:
   #   - uses: actions/checkout@v4
   #   - id: run-tests
   #     if: needs.prepare_env.outputs.should-auto-succeed-regression-tests != 'true'
-  #     uses: ./.github/workflows/composite-actions/regression-tests
+  #     uses: ./.github/actions/regression-tests
   #   - id: auto-succeed-tests
   #     if: needs.prepare_env.outputs.should-auto-succeed-regression-tests == 'true'
   #     run: |
@@ -92,4 +92,4 @@ jobs:
         echo "Kubernetes Gateway API conformance tests auto-succeeded"
     - id: run-tests
       if: needs.prepare_env.outputs.should-auto-succeed-regression-tests != 'true'
-      uses: ./.github/workflows/composite-actions/kube-gateway-api-conformance-tests
+      uses: ./.github/actions/kube-gateway-api-conformance-tests

.github/workflows/static-analysis.yaml

@@ -18,7 +18,7 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v4
     - name: Prep Go Runner
-      uses: ./.github/workflows/composite-actions/prep-go-runner
+      uses: ./.github/actions/prep-go-runner
     - name: Generate Code
       run: |
         ./ci/check-generated-code.sh
@@ -34,7 +34,7 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v4
     - name: Prep Go Runner
-      uses: ./.github/workflows/composite-actions/prep-go-runner
+      uses: ./.github/actions/prep-go-runner
     - uses: golangci/golangci-lint-action@v6
       # `make analyze` runs the linter with similar arguments to what we use here.
       # If this action fails, try running `make analyze` locally.

.github/workflows/trivy-analysis-scheduled.yaml

@@ -31,7 +31,7 @@ jobs:
           sudo dpkg -i trivy_${TRIVY_VERSION}_Linux-64bit.deb
       - name: Check out code into the Go module directory
         uses: actions/checkout@v4
-      - uses: ./.github/workflows/composite-actions/prep-go-runner
+      - uses: ./.github/actions/prep-go-runner
       - name: Setup - gcloud / gsutil
         uses: 'google-github-actions/auth@v2'
         with: