Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the stale example/ directory #10424

Merged

Conversation

timflannagan
Copy link
Member

Description

Quick cleanup PR that removes the stale (or at least appears to be stale going forward) example/ directory.

Context

Noticed this while researching #10423.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
Copy link
Member Author

There's some references to this example directory in the docs/ directory. I held off on purging those since the docs/ directory is another cleanup target and we can tackle that over time.

@nfuden
Copy link
Contributor

nfuden commented Jan 9, 2025

How would you feel about stubbing out this directory and adding a README? I like the concept of examples

@timflannagan
Copy link
Member Author

@nfuden Not a bad idea, although it feels a bit premature given overlap with the docs site + test/e2e YAML examples. I can create a tracker for boostrapping a proper example/ directory and seeing what should live there? WYDT?

@yuval-k
Copy link
Contributor

yuval-k commented Jan 9, 2025

@jenshu jenshu added this pull request to the merge queue Jan 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 10, 2025
@yuval-k yuval-k added this pull request to the merge queue Jan 10, 2025
@ilrudie ilrudie removed this pull request from the merge queue due to a manual request Jan 10, 2025
@ilrudie ilrudie added this pull request to the merge queue Jan 10, 2025
Merged via the queue into kgateway-dev:main with commit f6b2b63 Jan 10, 2025
9 of 18 checks passed
@timflannagan timflannagan deleted the chore/remove-stale-examples-dir branch January 10, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants