Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ingresses-only flag #69

Closed
wants to merge 0 commits into from
Closed

added ingresses-only flag #69

wants to merge 0 commits into from

Conversation

camperjett
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
this adds a new flag ingresses-only to scope the tool to only convert resources without looking for providers CRDs

Which issue(s) this PR fixes:
Fixes #67

Does this PR introduce a user-facing change?:

NONE

/cc @LiorLieberman

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 28, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 28, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: camperjett / name: Jaideep Sharma (b131dff)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 28, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @camperjett!

It looks like this is your first PR to kubernetes-sigs/ingress2gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress2gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 28, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @camperjett. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 28, 2023
levikobi
levikobi suggested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @camperjett!

Removing the gateway objects is not exactly what we had in mind here. What we intended to do was to not translate provider-specific functionality by not running provider converters.
Maybe you can take a look at https://github.com/kubernetes-sigs/ingress2gateway#usage for some reference.

Let me know if you have any questions.

@camperjett
Copy link
Author

camperjett commented Oct 1, 2023 •
edited
Loading

Okay. This is similar to passing empty list of providers in function i2gw.ToGatewayAPIResources(...) right? Should I do that? (In file cmd/print.go, Inside function PrintGatewaysAndHTTPRoutes(...))

@levikobi
Copy link
Member

levikobi commented Oct 2, 2023

Okay. This is similar to passing empty list of providers in function i2gw.ToGatewayAPIResources(...) right? Should I do that? (In file cmd/print.go, Inside function PrintGatewaysAndHTTPRoutes(...))

Yes that seems about right

One more thing that comes to mind, this flag should probably be mutually exclusive with the providers flag

levikobi
levikobi reviewed Oct 2, 2023
View reviewed changes
cmd/print.go Outdated
@@ -182,6 +190,7 @@ if specified with --namespace.`)
cmd.Flags().StringSliceVar(&pr.providers, "providers", i2gw.GetSupportedProviders(),
fmt.Sprintf("If present, the tool will try to convert only resources related to the specified providers, supported values are %v", i2gw.GetSupportedProviders()))

cmd.Flags().BoolVar(&pr.ingressesOnly, "ingresses-only", false, "If present, the tool will only print the converted Ingresses.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mutually exclusive with the providers flag

@camperjett camperjett closed this Oct 7, 2023
@camperjett camperjett force-pushed the add-ingressonly-flag branch from b131dff to df5c050 Compare October 7, 2023 10:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camperjett

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2023
@camperjett
Copy link
Author

PTAL at
#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levikobi levikobi levikobi requested changes

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a ingresses-only flag
3 participants
@camperjett @k8s-ci-robot @levikobi