Skip to content

Commit

Permalink
Revert non-public tapped method calls
Browse files Browse the repository at this point in the history
Since tap tries to call the methods technically from outside
  • Loading branch information
shaedrich authored Dec 4, 2024
1 parent 76fd6c9 commit d167b2a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/Illuminate/Database/Eloquent/Builder.php
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,9 @@ public function __call($method, $parameters)
return $this->toBase()->{$method}(...$parameters);
}

return tap($this)->forwardCallTo($this->query, $method, $parameters);
$this->forwardCallTo($this->query, $method, $parameters);

return $this;
}

/**
Expand Down
4 changes: 3 additions & 1 deletion src/Illuminate/Foundation/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,9 @@ public function setBasePath($basePath)
{
$this->basePath = rtrim($basePath, '\/');

return tap($this)->bindPathsInContainer();
$this->bindPathsInContainer();

return $this;
}

/**
Expand Down

0 comments on commit d167b2a

Please sign in to comment.