Php 84 support

[markwalet]

This pull request attempts to upgrade laravel-zero/framework v11.

To do this, support for PHP 8.2 had to be dropped. (source)

The original reason behind this upgrade is because of deprecation warnings in the nesbot/carbon dependency while running on PHP 8.4:

bash-5.1# ./vendor/bin/pint --test
PHP Deprecated:  Carbon\Traits\Date::getDaysFromStartOfWeek(): Implicitly marking parameter $weekStartsAt as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/Traits/Date.php on line 1394
PHP Deprecated:  Carbon\Traits\Date::setDaysFromStartOfWeek(): Implicitly marking parameter $weekStartsAt as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/Traits/Date.php on line 1412
PHP Deprecated:  Carbon\Traits\Date::utcOffset(): Implicitly marking parameter $minuteOffset as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/Traits/Date.php on line 1481
PHP Deprecated:  Carbon\Traits\Localization::locale(): Implicitly marking parameter $locale as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/Traits/Localization.php on line 447
PHP Deprecated:  Carbon\Traits\Test::setDefaultTimezone(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/Traits/Test.php on line 203
PHP Deprecated:  Carbon\CarbonTimeZone::toOffsetName(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/CarbonTimeZone.php on line 158
PHP Deprecated:  Carbon\CarbonTimeZone::toOffsetTimeZone(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/CarbonTimeZone.php on line 172
PHP Deprecated:  Carbon\CarbonTimeZone::toRegionName(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/CarbonTimeZone.php on line 188
PHP Deprecated:  Carbon\CarbonTimeZone::toRegionTimeZone(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead in phar:///var/www/vendor/laravel/pint/builds/pint/vendor/nesbot/carbon/src/Carbon/CarbonTimeZone.php on line 230

  ........................................................................................................................................................................................
  ........................................................................................................................................................................................
  ........................................................................................................................................................................................
  ........................................................................................................................................................................................
  ........................................................................................................................................................................................
  ........................

  ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Laravel
    PASS   ..................................................................................................................................................................... 944 files

This deprecation warnings are resolved in version 3 in Carbon, but this version is only supported in Laravel 11. So that's why I thought this bit of system maintenance could be helpful. It does drop support for PHP 8.1 but that version hasn't been in active support for over a year.

Let me know if anything else is needed. Keep up the great work! 🚀

[markwalet]

I have no clue why phpstan is failing. There is no GitPathsRepository::processFileNames() in my repository.

[Jubeki]

I have no clue why phpstan is failing. There is no GitPathsRepository::processFileNames() in my repository.

You need to change the following Line:

pint/app/Repositories/GitPathsRepository.php

Line 82 in cc904c0

* @param \Illuminate\Support\Collection<int, string> $fileNames

to

@param  \Illuminate\Support\Collection<int, non-falsy-string>  $fileNames

[markwalet]

You need to change the following Line:

I see, it seems like it did some weird stuff because I didn't have this line in my repository. It looks like it was added recently. I synced the fork and merged main into my branch. It is changed now and the tests are successful.

[markwalet]

@taylorotwell I see you marked the PR as draft, but the CI issues were already fixed. Any feedback I need to process before we can review again?

[Jubeki]

@taylorotwell I see you marked the PR as draft, but the CI issues were already fixed. Any feedback I need to process before we can review again?

I think he is waiting for a review from @nunomaduro (See the reviewers section on the right side)