Fix: RemovedInSphinx80Warning #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deprecated. Use (obj.__name__, obj.object) instead
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 12 12
Lines 1035 1036 +1
=======================================
+ Hits 992 993 +1
Misses 43 43 ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR. Sorry for taking so long - I will soon take a look at it more closely. |
mansenfranzen
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Looks good to me - have to trigger the CI pipeline because it likely breaks older Sphinx versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #174. I tested this with sphinx 7.2.6, I am not sure if this would cause problem with earlier versions.