fix: issue where linked mode enabled in tests (#186)

marko-js · Jan 7, 2025 · 85ccd2f · 85ccd2f
1 parent 9c2f2e2
commit 85ccd2f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/blue-humans-boil.md b/.changeset/blue-humans-boil.md
@@ -0,0 +1,5 @@
+---
+"@marko/vite": patch
+---
+
+Fix issue where link mode was incorrectly left enabled in test environments.
diff --git a/src/index.ts b/src/index.ts
@@ -167,6 +167,12 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
       enforce: "pre", // Must be pre to allow us to resolve assets before vite.
       async config(config, env) {
         let optimize = env.mode === "production";
+        isTest = env.mode === "test";
+        isBuild = env.command === "build";
+
+        if (isTest) {
+          linked = false;
+        }
 
         if ("MARKO_DEBUG" in process.env) {
           optimize =
@@ -239,8 +245,6 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
         compiler.configure(baseConfig);
         devEntryFile = path.join(root, "index.html");
         devEntryFilePosix = normalizePath(devEntryFile);
-        isTest = env.mode === "test";
-        isBuild = env.command === "build";
         isSSRBuild = isBuild && linked && Boolean(config.build!.ssr);
         renderAssetsRuntimeCode = getRenderAssetsRuntime({
           isBuild,
@@ -249,7 +253,6 @@ export default function markoPlugin(opts: Options = {}): vite.Plugin[] {
         });
 
         if (isTest) {
-          linked = false;
           const { test } = config as any;
 
           if ((test.environment as string | undefined)?.includes("dom")) {