Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeliveryMode.Stream + BotToBot simplify #41

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

DeliveryMode.Stream + BotToBot simplify #41

wants to merge 12 commits into from

Conversation

tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented Jan 15, 2025 •
edited
Loading

Fixes #29
Fixes #30

  • Added streamed replies when using Activity.DeliveryMode = DeliveryModes.Stream
  • Changed IChannel to support using streamed replies. Still supports non-stream DeliveryMode
  • ConversationIdFactory supports lookup by either the channelConversationId or the conversationId+Alias. This eliminates having to separately store this relation in State.

Tracy Boehrer added 3 commits January 15, 2025 07:47
Merge branch 'main' into users/tracyboehrer/bot-to-bot-simplify
d4b3dfa 
# Conflicts:
#	src/libraries/Client/Microsoft.Agents.Client/ConfigurationChannelHost.cs
#	src/libraries/Hosting/AspNetCore/ChannelApiController.cs
#	src/libraries/Hosting/AspNetCore/ServiceCollectionExtensions.cs
#	src/samples/BotToBot/Bot1/Bot1.csproj
#	src/samples/BotToBot/Bot1/Program.cs
#	src/samples/BotToBot/Bot1/Properties/launchSettings.json
#	src/samples/BotToBot/Bot1/appsettings.json
#	src/samples/BotToBot/Bot2/Bot2.csproj
#	src/samples/BotToBot/Bot2/Properties/launchSettings.json
Fixed merge issues
ed4f7ca
Merge branch 'main' into users/tracyboehrer/bot-to-bot-simplify
0f18ff5 
# Conflicts:
#	src/libraries/Hosting/AspNetCore/CloudAdapter.cs
#	src/tests/Microsoft.Agents.BotBuilder.Adapter.Tests/Teams/TeamsActivityHandlerTests.cs
@github-actions github-actions bot added ML: Samples Tags changes to samples ML: Core Tags changes to core libraries ML: Tests Tags changes to tests labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattB-msft MattB-msft Awaiting requested review from MattB-msft

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ML: Core Tags changes to core libraries ML: Samples Tags changes to samples ML: Tests Tags changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BotToBot to use new DeliveryModes.Stream New DeliveryMode: Stream
1 participant
@tracyboehrer