File Actions menu #31220
File Actions menu #31220
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| </ui:MenuItem.Icon> | ||
| </ui:MenuItem> | ||
| <Separator/> | ||
| <ui:MenuItem Header="Copy path of files sperated by"> |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
|
@niels9001 Do you have an idea why the contextmenu doesn't take the WPFUI style? |
… to replace filename with hash
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
|
@stefansjfw All your comments are now adressed |
| @@ -25,7 +25,9 @@ public static Frame Frame | |||
| { | |||
| if (frame == null) | |||
| { | |||
| #pragma warning disable WinUIEx1001 // The member will always be null. | |||
There was a problem hiding this comment.
we are referencing something that will (according to WinUIEx) always be null. If the version bump of WinUIEx introduced this, this can't go in like this. We should make sure that this is safe to do. Hence, my question above...
src/modules/FileActionsMenu/FileActionsMenu/FileActionsMenu.base.rc
Outdated
Show resolved
Hide resolved
|
@stefansjfw I adressed your remaining comments. Thank you for the review. |
|
@stefansjfw Thank you so much for fixing the issues. Is there anything left I have to do? |
|
@Aaron-Junker |
Give it some more testing I guess :) will do the same tomorrow. I also asked @niels9001 to revisit icon and screenshots |
…/microsoft/PowerToys into dev/aaron-junker/FileActionsMenu
| <tkcontrols:SettingsCard | ||
| x:Uid="Activation_Shortcut" | ||
| HeaderIcon="{ui:FontIcon Glyph=}" | ||
| IsEnabled="{x:Bind ViewModel.FileActionsMenuIsEnabled, Mode=OneWay}"> | ||
| <controls:ShortcutControl MinWidth="{StaticResource SettingActionControlMinWidth}" HotkeySettings="{x:Bind Path=ViewModel.FileActionsMenuShortcut, Mode=TwoWay}" /> | ||
| </tkcontrols:SettingsCard> |
There was a problem hiding this comment.
To be aligned with other pages, shouldn't this be a settings group?
Summary of the Pull Request
Adding a new menu invokable by selecting files in explorer and pressing a shortcut set in the settings.
Screenshots
PR Checklist
Detailed Description of the Pull Request / Additional comments
Things left to do:
Validation Steps Performed