fix(60563):@import * as namespace cannot be used with @implements #60566

a-tarasyuk · 2024-11-23T00:57:22Z

Fixes #60563

…heritage clause

src/compiler/utilities.ts

…ix/60563

jakebailey · 2025-01-17T21:15:24Z

@typescript-bot test it

typescript-bot · 2025-01-17T21:15:28Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-17T21:35:23Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60566/merge:

Everything looks good!

typescript-bot · 2025-01-17T21:35:52Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-17T21:58:37Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,133k (± 0.83%)}	_{196,298k (± 0.75%)}	_~	_193,291k	_196,962k	_{p=0.128 n=6}
_{Parse Time}	_{1.61s (± 0.73%)}	_{1.59s (± 1.43%)}	_~	_1.55s	_1.62s	_{p=0.117 n=6}
_{Bind Time}	_{0.88s (± 1.38%)}	_{0.88s (± 0.85%)}	_~	_0.87s	_0.89s	_{p=0.555 n=6}
_{Check Time}	_{11.80s (± 0.55%)}	_{11.77s (± 0.39%)}	_~	_11.72s	_11.85s	_{p=0.518 n=6}
_{Emit Time}	_{3.38s (± 4.19%)}	_{3.35s (± 3.24%)}	_~	_3.26s	_3.56s	_{p=1.000 n=6}
_{Total Time}	_{17.68s (± 0.56%)}	_{17.60s (± 0.68%)}	_~	_17.48s	_17.82s	_{p=0.172 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,969	_947,969	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,815k (± 0.00%)}	_{1,225,819k (± 0.00%)}	_~	_1,225,776k	_1,225,888k	_{p=0.936 n=6}
_{Parse Time}	_{8.03s (± 0.79%)}	_{8.09s (± 0.42%)}	_~	_8.06s	_8.14s	_{p=0.108 n=6}
_{Bind Time}	_{2.29s (± 0.58%)}	_{2.29s (± 0.98%)}	_~	_2.25s	_2.31s	_{p=0.742 n=6}
_{Check Time}	_{38.19s (± 0.37%)}	_{38.38s (± 0.57%)}	_~	_38.12s	_38.77s	_{p=0.077 n=6}
_{Emit Time}	_{18.26s (± 0.74%)}	_{18.29s (± 0.42%)}	_~	_18.18s	_18.37s	_{p=0.575 n=6}
_{Total Time}	_{66.77s (± 0.12%)}	_{67.05s (± 0.33%)}	_{+0.28s (+ 0.42%)}	_66.67s	_67.28s	_{p=0.045 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,444,602	_2,444,602	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,634	_896,634	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,305,808k (± 0.00%)}	_{2,305,741k (± 0.01%)}	_~	_2,305,420k	_2,305,969k	_{p=0.810 n=6}
_{Parse Time}	_{10.77s (± 0.21%)}	_{10.74s (± 0.55%)}	_~	_10.67s	_10.82s	_{p=0.468 n=6}
_{Bind Time}	_{2.52s (± 0.65%)}	_{2.51s (± 0.30%)}	_~	_2.50s	_2.52s	_{p=0.216 n=6}
_{Check Time}	_{86.96s (± 0.32%)}	_{88.52s (± 2.20%)}	_{+1.56s (+ 1.80%)}	_87.16s	_92.11s	_{p=0.005 n=6}
_{Emit Time}	_{0.34s (± 1.50%)}	_{0.65s (±117.04%)}	_~	_0.33s	_2.21s	_{p=1.000 n=6}
_{Total Time}	_{100.59s (± 0.29%)}	_{102.42s (± 1.81%)}	_{+1.84s (+ 1.82%)}	_100.69s	_105.67s	_{p=0.031 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,455	_1,228,455	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,871	_266,871	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,606,660k (±14.40%)}	_{2,970,275k (± 9.99%)}	_~	_2,364,017k	_3,092,593k	_{p=0.173 n=6}
_{Parse Time}	_{6.61s (± 1.09%)}	_{6.71s (± 1.34%)}	_{+0.10s (+ 1.46%)}	_6.53s	_6.76s	_{p=0.045 n=6}
_{Bind Time}	_{2.18s (± 0.90%)}	_{2.14s (± 1.61%)}	_{-0.05s (- 2.14%)}	_2.09s	_2.18s	_{p=0.036 n=6}
_{Check Time}	_{42.78s (± 0.58%)}	_{42.82s (± 0.24%)}	_~	_42.71s	_43.01s	_{p=0.810 n=6}
_{Emit Time}	_{3.55s (± 3.04%)}	_{3.51s (± 1.76%)}	_~	_3.42s	_3.61s	_{p=0.810 n=6}
_{Total Time}	_{55.12s (± 0.56%)}	_{55.17s (± 0.32%)}	_~	_54.89s	_55.43s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,455	_1,228,455	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,871	_266,871	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,157,700k (± 0.03%)}	_{3,036,002k (± 9.76%)}	_~	_2,430,704k	_3,158,150k	_{p=0.230 n=6}
_{Parse Time}	_{8.71s (± 0.70%)}	_{8.67s (± 1.17%)}	_~	_8.48s	_8.77s	_{p=0.470 n=6}
_{Bind Time}	_{2.64s (± 0.78%)}	_{2.63s (± 1.07%)}	_~	_2.62s	_2.69s	_{p=0.573 n=6}
_{Check Time}	_{53.34s (± 0.57%)}	_{53.32s (± 0.39%)}	_~	_53.00s	_53.54s	_{p=0.810 n=6}
_{Emit Time}	_{4.32s (± 1.99%)}	_{4.34s (± 1.98%)}	_~	_4.26s	_4.45s	_{p=0.748 n=6}
_{Total Time}	_{69.01s (± 0.51%)}	_{68.96s (± 0.44%)}	_~	_68.42s	_69.34s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,628	_262,628	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,697	_106,697	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,849k (± 0.02%)}	_{440,760k (± 0.02%)}	_~	_440,670k	_440,852k	_{p=0.093 n=6}
_{Parse Time}	_{3.54s (± 0.79%)}	_{3.53s (± 0.81%)}	_~	_3.50s	_3.58s	_{p=0.416 n=6}
_{Bind Time}	_{1.32s (± 0.92%)}	_{1.32s (± 1.12%)}	_~	_1.30s	_1.34s	_{p=0.934 n=6}
_{Check Time}	_{19.08s (± 0.44%)}	_{19.02s (± 0.77%)}	_~	_18.80s	_19.21s	_{p=0.471 n=6}
_{Emit Time}	_{1.53s (± 0.34%)}	_{1.53s (± 1.14%)}	_~	_1.52s	_1.56s	_{p=0.557 n=6}
_{Total Time}	_{25.47s (± 0.30%)}	_{25.40s (± 0.58%)}	_~	_25.18s	_25.61s	_{p=0.378 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,095	_226,095	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,636k (± 0.01%)}	_{371,674k (± 0.01%)}	_~	_371,606k	_371,758k	_{p=0.298 n=6}
_{Parse Time}	_{2.90s (± 0.52%)}	_{2.91s (± 1.34%)}	_~	_2.84s	_2.95s	_{p=0.291 n=6}
_{Bind Time}	_{1.59s (± 0.83%)}	_{1.58s (± 1.46%)}	_~	_1.54s	_1.60s	_{p=0.615 n=6}
_{Check Time}	_{16.46s (± 0.22%)}	_{16.48s (± 0.40%)}	_~	_16.41s	_16.60s	_{p=0.374 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.96s (± 0.19%)}	_{20.98s (± 0.46%)}	_~	_20.85s	_21.10s	_{p=0.748 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,251,895	_3,251,895	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,119,160	_1,119,160	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,317,092k (± 0.01%)}	_{3,316,915k (± 0.01%)}	_~	_3,316,574k	_3,317,374k	_{p=0.470 n=6}
_{Parse Time}	_{14.19s (± 0.74%)}	_{14.17s (± 0.61%)}	_~	_14.08s	_14.29s	_{p=0.748 n=6}
_{Bind Time}	_{4.58s (± 0.36%)}	_{4.59s (± 0.30%)}	_~	_4.58s	_4.61s	_{p=0.249 n=6}
_{Check Time}	_{88.84s (± 2.23%)}	_{90.93s (± 2.62%)}	_~	_88.05s	_94.82s	_{p=0.093 n=6}
_{Emit Time}	_{27.24s (± 7.13%)}	_{28.17s (± 2.49%)}	_~	_27.53s	_29.13s	_{p=0.810 n=6}
_{Total Time}	_{134.86s (± 0.85%)}	_{137.86s (± 1.48%)}	_{+3.00s (+ 2.23%)}	_135.87s	_141.72s	_{p=0.013 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,595	_291,595	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,971	_118,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,397k (± 0.02%)}	_{445,424k (± 0.04%)}	_~	_445,145k	_445,660k	_{p=0.378 n=6}
_{Parse Time}	_{4.12s (± 1.18%)}	_{4.10s (± 0.61%)}	_~	_4.06s	_4.13s	_{p=0.261 n=6}
_{Bind Time}	_{1.78s (± 1.48%)}	_{1.76s (± 1.06%)}	_~	_1.74s	_1.79s	_{p=0.326 n=6}
_{Check Time}	_{18.85s (± 0.53%)}	_{18.82s (± 0.72%)}	_~	_18.68s	_19.02s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.76s (± 0.50%)}	_{24.69s (± 0.61%)}	_~	_24.54s	_24.91s	_{p=0.575 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,050	_555,050	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,115	_186,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{493,911k (± 0.01%)}	_{493,915k (± 0.01%)}	_~	_493,874k	_493,946k	_{p=0.810 n=6}
_{Parse Time}	_{2.77s (± 0.23%)}	_{2.76s (± 0.19%)}	_~	_2.76s	_2.77s	_{p=0.091 n=6}
_{Bind Time}	_{0.96s (± 0.93%)}	_{0.96s (± 0.88%)}	_~	_0.94s	_0.96s	_{p=0.437 n=6}
_{Check Time}	_{16.27s (± 0.20%)}	_{16.26s (± 0.30%)}	_~	_16.19s	_16.33s	_{p=0.574 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.00s (± 0.15%)}	_{19.98s (± 0.22%)}	_~	_19.92s	_20.04s	_{p=0.418 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-17T22:50:17Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60566/merge:

Everything looks good!

fix(60563): treat JSDoc implements tag as identifier in non-emitting …

6586021

…heritage clause

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 23, 2024

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 10, 2025

jakebailey reviewed Jan 17, 2025

View reviewed changes

src/compiler/utilities.ts Outdated Show resolved Hide resolved

a-tarasyuk added 2 commits January 17, 2025 22:59

consider type only alias as valid for jsdoc context

82e76ec

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

cb0714c

…ix/60563

a-tarasyuk requested a review from jakebailey January 17, 2025 21:03

jakebailey approved these changes Jan 17, 2025

View reviewed changes

jakebailey merged commit a086a3c into microsoft:main Jan 17, 2025
32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(60563):@import * as namespace cannot be used with @implements #60566

fix(60563):@import * as namespace cannot be used with @implements #60566

a-tarasyuk commented Nov 23, 2024 •

edited

Loading

jakebailey commented Jan 17, 2025

typescript-bot commented Jan 17, 2025 •

edited

Loading

typescript-bot commented Jan 17, 2025

typescript-bot commented Jan 17, 2025

typescript-bot commented Jan 17, 2025

tsc

typescript-bot commented Jan 17, 2025

fix(60563):@import * as namespace cannot be used with @implements #60566

fix(60563):@import * as namespace cannot be used with @implements #60566

Conversation

a-tarasyuk commented Nov 23, 2024 • edited Loading

jakebailey commented Jan 17, 2025

typescript-bot commented Jan 17, 2025 • edited Loading

typescript-bot commented Jan 17, 2025

typescript-bot commented Jan 17, 2025

typescript-bot commented Jan 17, 2025

tsc

typescript-bot commented Jan 17, 2025

a-tarasyuk commented Nov 23, 2024 •

edited

Loading

typescript-bot commented Jan 17, 2025 •

edited

Loading