-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved cosmos job hosting to use unified retry logic #4773
Merged
mikaelweave
merged 15 commits into
main
from
personal/mikaelw/fix-cosmos-jobhosting-exception-handling
Jan 15, 2025
Merged
Moved cosmos job hosting to use unified retry logic #4773
mikaelweave
merged 15 commits into
main
from
personal/mikaelw/fix-cosmos-jobhosting-exception-handling
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelweave
added
Bug
Bug bug bug.
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
labels
Jan 14, 2025
src/Microsoft.Health.Fhir.Core/Features/Operations/Reindex/ReindexJobWorker.cs
Fixed
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.CosmosDb/Features/Storage/RetryExceptionPolicyFactory.cs
Fixed
Show fixed
Hide fixed
fhibf
reviewed
Jan 15, 2025
src/Microsoft.Health.Fhir.CosmosDb/Features/Storage/RetryExceptionPolicyFactory.cs
Outdated
Show resolved
Hide resolved
fhibf
reviewed
Jan 15, 2025
src/Microsoft.Health.Fhir.CosmosDb.UnitTests/Features/Storage/Queues/CosmosQueueClientTests.cs
Outdated
Show resolved
Hide resolved
fhibf
approved these changes
Jan 15, 2025
mikaelweave
deleted the
personal/mikaelw/fix-cosmos-jobhosting-exception-handling
branch
January 15, 2025 23:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
Bug
Bug bug bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves CosmosDB jobs to use unified exception logic. This will fix issues where 503 errors from CosmosDB are not being retried correctly in job hosting functions.
Related issues
AB#136882
Testing
Unit tests
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)