Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer URL for Cloudflare.Warp with the version-specific address #213644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Jan 18, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Fixes #213643

I got the URL from https://github.com/cloudflare/cloudflare-docs/tree/84eb1ed98a6991608742c51cccb64d6339aeb0b5/src/content/warp-releases/windows/ga

And I have checked the hash on WSL2 as below

> curl -o fixed-url https://downloads.cloudflareclient.com/v1/download/windows/version/2024.12.760.0
> curl -L -o unstable-url https://1111-releases.cloudflareclient.com/windows/Cloudflare_WARP_Release-x64.msi
> sha256sum *
632246671d77ca806a172fdc355d0299d8c42157edca89e9dd123c5847b4dba4  fixed-url
632246671d77ca806a172fdc355d0299d8c42157edca89e9dd123c5847b4dba4  unstable-url
Microsoft Reviewers: Open in CodeFlow

I got the URL from https://github.com/cloudflare/cloudflare-docs/tree/84eb1ed98a6991608742c51cccb64d6339aeb0b5/src/content/warp-releases/windows/ga

And I have checked the hash on WSL2 as below

```console
> curl -o fixed-url https://downloads.cloudflareclient.com/v1/download/windows/version/2024.12.760.0
> curl -L -o unstable-url https://1111-releases.cloudflareclient.com/windows/Cloudflare_WARP_Release-x64.msi
> sha256sum *
632246671d77ca806a172fdc355d0299d8c42157edca89e9dd123c5847b4dba4  fixed-url
632246671d77ca806a172fdc355d0299d8c42157edca89e9dd123c5847b4dba4  unstable-url
```
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Jan 18, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 18, 2025
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 18, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 18, 2025
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 18, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 19, 2025
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 19, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 19, 2025
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 19, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 19, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Retry-1 flag to indicate retried Validation-Completed Validation passed Validation-Retry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Issue]: Cloudflare.Warp - It is using unstable installer URL
4 participants