Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate package: Stardock.Start11 to Stardock.Start11.v2 #213771

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Migrate package: Stardock.Start11 to Stardock.Start11.v2 #213771

wants to merge 3 commits into from
+54 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Jan 19, 2025 •
edited by microsoft-github-policy-service bot
Loading

What's changed

  • Also bump version from "2.1.1.0" to "2.5.0.0"

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@Dragon1573
Migrate package: Stardock.Start11 to Stardock.Start11.v2
1f011ed 
- Also bump version from "2.1.1.0" to "2.5.0.0"

Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 19, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 19, 2025
@Dragon1573
Apply suggestions from code review
917ab78 
- Correction of "Package Identifier" property
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Jan 19, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 19, 2025
@Dragon1573
Apply suggestions from code review
e7ad7f6 
- Correction of manifest files name
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 19, 2025
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 688e5cfda9383fe8d236ebf4a4052a382c6db594cfc5c2f9887ef6232035e821
    • manifests\s\Stardock\Start11\2.5.0.0

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Package Possible-Duplicate Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Issue]: Stardock.Start11
4 participants
@Dragon1573 @wingetbot @ItzLevvie @stephengillie