Implement the final RFC9369 version of QUIC v2 #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea for how to re-generate the binary samples that are part of the (failing) tests? Is there a script or do I simply copy in the values from the test failure output? |
|
I generally double-check the encodings. For things that involve crypto, you should be able to use quicwg/base-drafts#4997 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
==========================================
- Coverage 87.99% 87.99% -0.01%
==========================================
Files 117 117
Lines 37630 37627 -3
==========================================
- Hits 33112 33109 -3
Misses 4518 4518 ☔ View full report in Codecov by Sentry. |
larseggert
requested review from
KershawChang and
martinthomson
as code owners
|
Interops with www.haproxy.org and test.privateoctopus.com:4433. |
martinthomson
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wireshark can decode our test traffic. Leaving as a draft PR until I can test against someone else's public server.