Skip to content

Commit

Permalink
e2ab916b feat(eslint-plugin): add signalStoreFeatureShouldUseGenericT…
Browse files Browse the repository at this point in the history
…ype rule (#4454)
  • Loading branch information
web-flow authored Jul 23, 2024
1 parent b8aca98 commit 04c3334
Show file tree
Hide file tree
Showing 16 changed files with 21 additions and 11 deletions.
2 changes: 1 addition & 1 deletion commit_message
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b58ea227 docs: add Rainer Hahnekamp as a Collaborator (#4450)
e2ab916b feat(eslint-plugin): add signalStoreFeatureShouldUseGenericType rule (#4454)
2 changes: 1 addition & 1 deletion generated/docs/app/search-data.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion generated/docs/guide/eslint-plugin.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"id": "guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type",
"title": "signal-store-feature-should-use-generic-type",
"contents": "\n\n\n <div class=\"github-links\">\n <a href=\"https://github.com/ngrx/platform/edit/main/projects/ngrx.io/content/guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type.md?message=docs%3A%20describe%20your%20change...\" aria-label=\"Suggest Edits\" title=\"Suggest Edits\"><i class=\"material-icons\" aria-hidden=\"true\" role=\"img\">mode_edit</i></a>\n </div>\n\n\n<div class=\"content\">\n<h1 id=\"signal-store-feature-should-use-generic-type\">signal-store-feature-should-use-generic-type<a title=\"Link to this heading\" class=\"header-link\" aria-hidden=\"true\" href=\"guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type#signal-store-feature-should-use-generic-type\"><i class=\"material-icons\">link</i></a></h1>\n<p>A custom Signal Store feature that accepts an input should define a generic type.</p>\n<ul>\n<li><strong>Type</strong>: problem</li>\n<li><strong>Fixable</strong>: Yes</li>\n<li><strong>Suggestion</strong>: No</li>\n<li><strong>Requires type checking</strong>: No</li>\n<li><strong>Configurable</strong>: No</li>\n</ul>\n<!-- Everything above this generated, do not edit -->\n<!-- MANUAL-DOC:START -->\n\n</div>\n\n<!-- links to this doc:\n-->\n<!-- links from this doc:\n - guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type#signal-store-feature-should-use-generic-type\n - https://github.com/ngrx/platform/edit/main/projects/ngrx.io/content/guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type.md?message=docs%3A%20describe%20your%20change...\n-->"
}
6 changes: 3 additions & 3 deletions generated/navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -774,12 +774,12 @@
"prerelease": [
"local"
],
"build": "sha.b58ea227",
"build": "sha.e2ab916b",
"version": "18.0.2-local",
"codeName": "snapshot",
"isSnapshot": true,
"full": "18.0.2-local+sha.b58ea227",
"full": "18.0.2-local+sha.e2ab916b",
"branch": "master",
"commitSHA": "b58ea227abb527d849d852daa45123c2507921e4"
"commitSHA": "e2ab916bead64041387ca835494c72652a05c3ad"
}
}
3 changes: 3 additions & 0 deletions generated/sitemap.xml
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,9 @@
<url>
<loc>https://ngrx.io/guide/eslint-plugin/rules/signal-state-no-arrays-at-root-level</loc>
</url>
<url>
<loc>https://ngrx.io/guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type</loc>
</url>
<url>
<loc>https://ngrx.io/guide/eslint-plugin/rules/updater-explicit-return-type</loc>
</url>
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified generated/zips/ngrx-start/ngrx-start.zip
Binary file not shown.
Binary file modified generated/zips/router-store-selectors/router-store-selectors.zip
Binary file not shown.
Binary file modified generated/zips/store-walkthrough/store-walkthrough.zip
Binary file not shown.
Binary file modified generated/zips/store/store.zip
Binary file not shown.
Binary file modified generated/zips/testing-store/testing-store.zip
Binary file not shown.
10 changes: 6 additions & 4 deletions ngsw.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"configVersion": 1,
"timestamp": 1721721096370,
"timestamp": 1721753905741,
"index": "/index.html",
"assetGroups": [
{
Expand Down Expand Up @@ -644,6 +644,7 @@
"/generated/docs/guide/eslint-plugin/rules/prefix-selectors-with-select.json",
"/generated/docs/guide/eslint-plugin/rules/select-style.json",
"/generated/docs/guide/eslint-plugin/rules/signal-state-no-arrays-at-root-level.json",
"/generated/docs/guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type.json",
"/generated/docs/guide/eslint-plugin/rules/updater-explicit-return-type.json",
"/generated/docs/guide/eslint-plugin/rules/use-consistent-global-store-name.json",
"/generated/docs/guide/eslint-plugin/rules/use-effects-lifecycle-interface.json",
Expand Down Expand Up @@ -1165,7 +1166,7 @@
"/generated/docs/api/store/testing/createMockStore.json": "663c1e52adf767c756edb7c2ffaa581c1e1211e0",
"/generated/docs/api/store/testing/provideMockStore.json": "18ced3f3d9c9e21f0490aec1b53b9c5e0b345089",
"/generated/docs/api/store/union.json": "6352d4ef790fdb4832a794e32366f911e980f844",
"/generated/docs/app/search-data.json": "dc3ebb220e122b17bb805b4ec9d3415b92adf2be",
"/generated/docs/app/search-data.json": "c1581269720b6a168fd91c087e9aee7b0b665d43",
"/generated/docs/contributing.json": "4c7957c3c81d4b50e5084c18375edeadc6095cc1",
"/generated/docs/docs.json": "70f2e96f98c89284c124e2da590cc93fdc1fb4ec",
"/generated/docs/enterprise-support.json": "90f869e6046ad7448c0ffc2beecf0f181a6c174b",
Expand Down Expand Up @@ -1212,7 +1213,7 @@
"/generated/docs/guide/entity/interfaces.json": "01a467cd7b79d478d0c48d19f0959df3204b5195",
"/generated/docs/guide/entity/recipes/additional-state-properties.json": "98e93b7e15fd3c13dfe02cc5a5deabd2d4a736cc",
"/generated/docs/guide/entity/recipes/entity-adapter-with-feature-creator.json": "5edffa121caa403b5ab8dc90baa8c0e8ed000661",
"/generated/docs/guide/eslint-plugin.json": "61a917c42d77192001ad54ccfeb2cc1d9653e915",
"/generated/docs/guide/eslint-plugin.json": "a329595ed88a1234bdcd3119b55f0b98daa6ee47",
"/generated/docs/guide/eslint-plugin/install.json": "d9366da18a9949f85d22e8e68834cbc7976cbbd4",
"/generated/docs/guide/eslint-plugin/rules/avoid-combining-component-store-selectors.json": "9c07ff87ac2f1dbf1cf48b452b2ab0fcf98bcb93",
"/generated/docs/guide/eslint-plugin/rules/avoid-combining-selectors.json": "ae29861009449f62e959659e858ad3ffdbf85889",
Expand Down Expand Up @@ -1241,6 +1242,7 @@
"/generated/docs/guide/eslint-plugin/rules/prefix-selectors-with-select.json": "7641ace14723e7f2d2b3bee18dc9b37996ff582e",
"/generated/docs/guide/eslint-plugin/rules/select-style.json": "73ac8008a79429687b2e7d1a345ca627c7e06981",
"/generated/docs/guide/eslint-plugin/rules/signal-state-no-arrays-at-root-level.json": "86c87d3dc799199fadb6701ce2097cc68fde392e",
"/generated/docs/guide/eslint-plugin/rules/signal-store-feature-should-use-generic-type.json": "720cd4bd6da30b7f84bce31b880a0a99d2fdb048",
"/generated/docs/guide/eslint-plugin/rules/updater-explicit-return-type.json": "761ee177e1322b06fb654a5cf144e6b8df5f45f1",
"/generated/docs/guide/eslint-plugin/rules/use-consistent-global-store-name.json": "9fbcf6491240ed1ada71ea451399bf7d1eff8182",
"/generated/docs/guide/eslint-plugin/rules/use-effects-lifecycle-interface.json": "c9528752387544842874518a17db85f44b13d83a",
Expand Down Expand Up @@ -1379,7 +1381,7 @@
"/generated/images/marketing/concept-icons/universal.svg": "69516bc8a226c9df3c564f7a4f0fec1b66e7711f",
"/generated/images/marketing/features/feature-icon.svg": "2cf6c1c11faee80b101b38c91f02184dada8cbe2",
"/generated/images/marketing/home/ngrx-conf-badge.svg": "f6c369c9c05b4b4df3373a7fb31dd3f4e82c9a44",
"/generated/navigation.json": "1ae317164f461c475018ec3bee838cf574f44a24",
"/generated/navigation.json": "444f0026b8a45fe52d899bb5812a0c4278c97e53",
"/generated/resources.json": "187bbb4f63bac415553db8bc033d822bb0b5a47e",
"/index.html": "0e5c2cbd1d11f32e52df7b85141924d894c895e3",
"/light-theme.css": "af6e8fca0da10e9eed053318ea52c0434ddc7c53",
Expand Down
2 changes: 1 addition & 1 deletion stats.json

Large diffs are not rendered by default.

0 comments on commit 04c3334

Please sign in to comment.