Remove pepper, read secret from file and minimise the number of secrets #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1865 ↗︎
Details:
Review all test suite changes for PR #1844 ↗︎ |
|||||||||||||||
corrideat
force-pushed
the
remove-pepper
branch
3 times, most recently
from
ac568ae to
c05231d
Compare
taoeffect
reviewed
Feb 12, 2024
corrideat
force-pushed
the
remove-pepper
branch
from
c05231d to
29360d1
Compare
taoeffect
reviewed
Feb 12, 2024
| } | ||
|
|
||
| return Boom.internal('internal error') | ||
| }) | ||
|
|
||
| route.GET('/zkpp/{contract}/auth_hash', { | ||
| route.GET('/zkpp/{contractID}/auth_hash', { |
There was a problem hiding this comment.
Nice job on renaming these from contract to contractID 👍
taoeffect
reviewed
Feb 12, 2024
| // is not implemented. | ||
| // b. Alternatively, migration can be done without migrating password salt | ||
| // records. This requires user interaction to create new salt records | ||
| // on the new server. |
There was a problem hiding this comment.
Really well written and clear comment 👏, well done, thanks @corrideat!
taoeffect
reviewed
Feb 12, 2024
backend/zkppSalt.js
Outdated
Comment on lines
53
to
57
| const recordSecret = IkmPromise.then(IKM => Buffer.from(hashStringArray('private/recordSecret', IKM)).toString('base64')) | ||
| // corresponds to the key for the keyed Hash function in "Log in / session establishment" | ||
| const challengeSecret = 'secret' // TODO: generate randomly and store in DB under private prefix | ||
| const challengeSecret = IkmPromise.then(IKM => Buffer.from(hashStringArray('private/challengeSecret', IKM)).toString('base64')) | ||
| // corresponds to a component of s in Step 3 of "Salt registration" | ||
| const registrationSecret = 'secret' // TODO: generate randomly and store in DB under private prefix | ||
| const registrationSecret = IkmPromise.then(IKM => Buffer.from(hashStringArray('private/registrationSecret', IKM)).toString('base64')) |
There was a problem hiding this comment.
These values can be set in a initZkpp() function that gets called from database.js (see bottom of that file)
corrideat
force-pushed
the
remove-pepper
branch
from
29360d1 to
15e17a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.