Remove redundant shutdown check in batchlogprocessor

[cijothomas]

The check is already done by the LogProvider.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (9aea826) to head (af3ed12).
Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2514   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22953   22944    -9     
=====================================
- Hits       17881   17879    -2     
+ Misses      5072    5065    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lalitb]

So, we don't go with the approach in #2462 - i.e., having is_shutdown check in logger::emit()?

[cijothomas]

So, we don't go with the approach in #2462 - i.e., having is_shutdown check in logger::emit()?

Irrespective of that, this check is redundant, as processor's shutdown() cannot be called without going through provider, which already checks for duplicate shutdown.

[lalitb]

Irrespective of that, this check is redundant, as processor's shutdown() cannot be called without going through provider, which already checks for duplicate shutdown.

yes, #2462 does same thing, by removing the is_shutdown flag altogether from the processors and let logger::emit() also check for the flag.

[cijothomas]

Irrespective of that, this check is redundant, as processor's shutdown() cannot be called without going through provider, which already checks for duplicate shutdown.

yes, #2462 does same thing, by removing the is_shutdown flag altogether from the processors and let logger::emit() also check for the flag.

Got it. I'll revisit 2462 again. We discussed this a bit in yesterday's SIG too. I will share more comments/thoughts on that PR.