-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19624: move 4.13 tests to optional (EOL) #60778
base: master
Are you sure you want to change the base?
Conversation
@eifrach: This pull request references MGMT-19624 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/pj-rehearse ack |
@eifrach: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml
Outdated
Show resolved
Hide resolved
@@ -88,6 +88,7 @@ presubmits: | |||
job-release: "4.18" | |||
pj-rehearse.openshift.io/can-be-rehearsed: "true" | |||
name: pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-4-13 | |||
optional: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an annoying bug ci-operator
that when you have a job already and you change its always_run
field, it doesn't reflect in the actual config, see above line 77. To overcome this you should remove the entire job, run make update
then add the job back with always_run: false
then run make update
again
8706c01
to
e3ed701
Compare
ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml
Outdated
Show resolved
Hide resolved
e3ed701
to
8a8526e
Compare
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@eifrach: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor, eifrach The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.